chore: Remove "updated" for deactivated document #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Sidetree resolution is processing full operations first (create, recover, deactivate) having "updated" in the resolution result for deactivate document will lead to inconsistent behaviour. If there was a 'recover' operation in the chain it will return "updated" otherwise it will be empty. Also in this case "updated" means the anchoring time of last recover and not necessarily the last update. Closes trustbloc#668 Signed-off-by: Sandra Vrtikapa <sandra.vrtikapa@securekey.com>
Codecov Report
@@ Coverage Diff @@
## main #669 +/- ##
=======================================
Coverage 93.70% 93.70%
=======================================
Files 76 76
Lines 4207 4207
=======================================
Hits 3942 3942
Misses 148 148
Partials 117 117
Continue to review full report at Codecov.
|
fqutishat
approved these changes
Apr 8, 2022
bstasyszyn
approved these changes
Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Sidetree resolution is processing full operations first (create, recover, deactivate) having "updated" in the resolution result for deactivate document will lead to inconsistent behaviour. If there was a 'recover' operation in the chain it will return "updated" otherwise it will be empty. Also in this case "updated" means the anchoring time of last recover and not necessarily the last update.
Closes #668
Signed-off-by: Sandra Vrtikapa sandra.vrtikapa@securekey.com