Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add custom patches for also known as #680

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

sandrask
Copy link
Contributor

Add two custom patches for adding/removing also known as URIs:
-add-also-known-as
-remove-also-known-as

Closes #679

Signed-off-by: Sandra Vrtikapa sandra.vrtikapa@securekey.com

@cla-bot cla-bot bot added the cla-signed label Jul 26, 2022
@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #680 (0515ed5) into main (c7b1e3c) will increase coverage by 0.28%.
The diff coverage is 97.82%.

@@            Coverage Diff             @@
##             main     #680      +/-   ##
==========================================
+ Coverage   93.73%   94.02%   +0.28%     
==========================================
  Files          76       77       +1     
  Lines        4230     4317      +87     
==========================================
+ Hits         3965     4059      +94     
+ Misses        148      141       -7     
  Partials      117      117              
Impacted Files Coverage Δ
pkg/document/document.go 95.00% <50.00%> (+8.15%) ⬆️
pkg/document/diddocument.go 85.71% <100.00%> (+3.36%) ⬆️
pkg/patch/patch.go 93.81% <100.00%> (+1.95%) ⬆️
pkg/versions/1_0/doccomposer/composer.go 91.84% <100.00%> (+1.78%) ⬆️
...s/1_0/doctransformer/didtransformer/transformer.go 97.54% <100.00%> (ø)
.../1_0/operationparser/patchvalidator/alsoknownas.go 100.00% <100.00%> (ø)
...ns/1_0/operationparser/patchvalidator/validator.go 95.00% <100.00%> (+0.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7b1e3c...0515ed5. Read the comment docs.

@sandrask sandrask force-pushed the issue-679 branch 2 times, most recently from 662ee5b to f76b4ee Compare July 26, 2022 21:28
Add two custom patches for adding/removing also known as URIs:
-add-also-known-as
-remove-also-known-as

Closes trustbloc#679

Signed-off-by: Sandra Vrtikapa <sandra.vrtikapa@securekey.com>
@fqutishat fqutishat merged commit 0164aff into trustbloc:main Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add custom patches for also known as
3 participants