This repository has been archived by the owner on Aug 25, 2023. It is now read-only.
feat: add httpsig validation in gnap middleware #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #316 +/- ##
==========================================
- Coverage 86.40% 86.28% -0.13%
==========================================
Files 26 26
Lines 2082 2121 +39
==========================================
+ Hits 1799 1830 +31
- Misses 176 180 +4
- Partials 107 111 +4
Continue to review full report at Codecov.
|
baha-ai
force-pushed
the
gnap_sig_verify
branch
4 times, most recently
from
cc4e974 to
ba1c4cb
Compare
DRK3
approved these changes
Jun 29, 2022
fqutishat
approved these changes
Jul 12, 2022
aholovko
reviewed
Jul 12, 2022
aholovko
reviewed
Jul 12, 2022
aholovko
approved these changes
Jul 12, 2022
baha-ai
force-pushed
the
gnap_sig_verify
branch
4 times, most recently
from
1a8a7f4 to
43d8c3b
Compare
fqutishat
reviewed
Jul 12, 2022
This change adds http signature validation after gnap middleware request introspection step. closes trustbloc#315 Signed-off-by: Baha Shaaban <baha.shaaban@securekey.com>
fqutishat
approved these changes
Jul 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds http signature validation after gnap middleware request introspection step.
closes #315
Signed-off-by: Baha Shaaban baha.shaaban@securekey.com