refactor: Remove EDV from BDD tests #331
Conversation
Codecov Report
@@ Coverage Diff @@
## main #331 +/- ##
=======================================
Coverage 86.59% 86.59%
=======================================
Files 26 26
Lines 2223 2223
=======================================
Hits 1925 1925
Misses 186 186
Partials 112 112 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ypukhta
force-pushed
the
issue-326
branch
2 times, most recently
from
6680924 to
471c530
Compare
ypukhta
force-pushed
the
issue-326
branch
2 times, most recently
from
9f3bd05 to
aa5815a
Compare
test/bdd/pkg/kms/auth_edv_steps.go
Outdated
| ) | ||
|
|
||
| func (s *Steps) storeSecretInHubAuth(userName string) error { | ||
| func (s *Steps) loginIntoAuthServer(userName string) error { |
There was a problem hiding this comment.
Typo here - I think you mean logInToAuthServer
test/bdd/pkg/kms/kms_steps.go
Outdated
| if err != nil { | ||
| return err | ||
| } | ||
| //if err := s.createDID(u); err != nil { |
There was a problem hiding this comment.
Did you meant to leave this here?
test/bdd/pkg/kms/zcap.go
Outdated
| @@ -39,133 +27,32 @@ type signer interface { | |||
| Alg() string | |||
| } | |||
|
|
|||
| type authzKMSSigner struct { | |||
| type zCapAuthUserSigner struct { | |||
There was a problem hiding this comment.
Should be zcapAuthUserSigner not zCapAuthUserSigner
There was a problem hiding this comment.
(ZCAP is an acronym, so should be in all caps, except when at the beginning of an unexported name, in which case it's all lowercase)
test/bdd/pkg/kms/zcap.go
Outdated
| s *Steps | ||
| authzUser *user | ||
| } | ||
|
|
||
| func newAuthzKMSSigner(s *Steps, authzUser *user) *authzKMSSigner { | ||
| return &authzKMSSigner{s: s, authzUser: authzUser} | ||
| func newZCapAuthUserSigner(s *Steps, authzUser *user) *zCapAuthUserSigner { |
There was a problem hiding this comment.
Should be newZCAPAuthUserSigner not newZCapAuthUserSigner
| o.bearerToken = token | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
if this is not needed, remove plz bearerToken from options struct and behavior related to setting Authorization header in DoRequest method
| @@ -181,10 +174,3 @@ func WithSigner(signer requestSigner) Opt { | |||
| o.signer = signer | |||
| } | |||
| } | |||
|
|
|||
| // WithParsedResponse specifies type to unmarshal response body. | |||
| func WithParsedResponse(r interface{}) Opt { | |||
There was a problem hiding this comment.
consider cleaning up parsedResponse-related behavior as well (the same considerations as for bearerToken case above)
Signed-off-by: Yevgen Pukhta <eugene.pukhta@gmail.com> Signed-off-by: Yevgen Pukhta <eugene.pukhta@gmail.com>
Remove EDV support from KMS BDD tests
Signed-off-by: Yevgen Pukhta eugene.pukhta@gmail.com