Change requirement on pycrypto to pycryptodome #10
Conversation
RobertKirk
force-pushed
the
master
branch
2 times, most recently
from
ebbbef4
to
86054d4
Compare
pycrypto isn't maintained, possibly has some exploits, and doesn't work on python 3.8. pycryptodome is a maintained alternative that does. Change the location of imports to handle changes in package.
We should use the compatiblity layer for pycrypto as this provides the behaviour we expect.
|
Hello, any updates on the above? @leonardocsantoss This client SDK does not work on python 3.8 because of pycrypto, which in turn pulls in We have been successfully using this SDK with pycryptodome because it has a pycrypto-compatible interface. But we need to manually replace the dependency and this complicates our deployment process and incurs maintenance overhead. Can you therefore please merge this? Thank you |
|
I'm not allowed to merge this. So, I made a fork and change this that: https://github.com/leonardocsantoss/trustly-client-python |
|
@RobertKirk maybe you have permission to merge? |
|
@RobertKirk ping |
|
@kostas-zealid I don't, it needs at least 1 approving review by a reviewer with write access, sorry. |
pycrypto isn't maintained, possibly has some exploits, and doesn't work
on python 3.8. pycryptodome is a maintained alternative that does.