Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose StoredKey encryption parameters #1766

Merged
merged 13 commits into from
Nov 23, 2021
Merged

Expose StoredKey encryption parameters #1766

merged 13 commits into from
Nov 23, 2021

Conversation

optout21
Copy link
Contributor

@optout21 optout21 commented Nov 8, 2021

Description

Expose StoredKey encryption parameters, through C interface, as Json string.

StoredKey unit tests.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • Prefix PR title with [WIP] if necessary.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • I have read the guidelines for adding a new blockchain
  • If there is a related Issue, mention it in the description (e.g. Fixes #<issue_number> ).

@optout21 optout21 marked this pull request as ready for review November 8, 2021 17:18
@optout21 optout21 requested a review from hewigovens as a code owner November 8, 2021 17:18
@optout21 optout21 changed the title [WIP] Expose StoredKey encryption parameters Expose StoredKey encryption parameters Nov 8, 2021
@optout21 optout21 requested a review from vikmeup November 8, 2021 17:18
swift/Tests/Keystore/KeystoreKeyTests.swift Outdated Show resolved Hide resolved
swift/Tests/Keystore/KeystoreKeyTests.swift Outdated Show resolved Hide resolved
swift/Tests/Keystore/KeystoreKeyTests.swift Outdated Show resolved Hide resolved
tests/interface/TWStoredKeyTests.cpp Show resolved Hide resolved
@optout21 optout21 requested a review from vikmeup November 15, 2021 10:30
@optout21
Copy link
Contributor Author

optout21 commented Nov 22, 2021

Encryption parameters can be controlled from outside:

@vikmeup
Copy link
Contributor

vikmeup commented Nov 22, 2021

Weak level is with 4096, used currently

let's change it to 10K as it's usually a default option in many places

@hewigovens hewigovens merged commit e110188 into master Nov 23, 2021
@hewigovens hewigovens deleted the ar/storekey-params branch November 23, 2021 08:16
@optout21
Copy link
Contributor Author

Weak level is with 4096, used currently

let's change it to 10K as it's usually a default option in many places

I have added a new level, with 16k (power of 2); #1801 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants