Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Build]: Configure JNI build for use in Java on Linux/MacOS #3411

Merged
merged 12 commits into from
Sep 5, 2023
Merged

[Build]: Configure JNI build for use in Java on Linux/MacOS #3411

merged 12 commits into from
Sep 5, 2023

Conversation

satoshiotomakan
Copy link
Collaborator

@satoshiotomakan satoshiotomakan commented Sep 4, 2023 •
edited
Loading

Description

Configure the compilation of the libTrustWalletCore.so and libTrustWalletCore.dylib libraries for use in Java/Kotlin on Linux/MacOS.

How to test

Run .github/workflows/kotlin-ci.yml

Types of changes

Change CMakeLists.txt.
Add the step to build JNI for MacOS to the Kotlin CI workflow.

Checklist

  • Create pull request as draft initially, unless its complete.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • If there is a related Issue, mention it in the description.

If you're adding a new blockchain

  • I have read the guidelines for adding a new blockchain.

@satoshiotomakan satoshiotomakan changed the title [Build]: Configure JNI build for use in Java on Linux/MacOS platforms [Build]: Configure JNI build for use in Java on Linux/MacOS Sep 4, 2023
MaximPestryakov
MaximPestryakov approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@MaximPestryakov MaximPestryakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
I will add Kotlin related stuff

@satoshiotomakan satoshiotomakan merged commit b809ccc into master Sep 5, 2023
@satoshiotomakan satoshiotomakan deleted the s/build-jni-library branch September 5, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Milerius Milerius Milerius approved these changes

@MaximPestryakov MaximPestryakov MaximPestryakov approved these changes

@lamafab lamafab Awaiting requested review from lamafab

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@satoshiotomakan @MaximPestryakov @Milerius