Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TON]: Return non-bounceable address by default (BREAKING CHANGES) #3925

Merged
merged 8 commits into from
Jul 4, 2024

Conversation

satoshiotomakan
Copy link
Collaborator

@satoshiotomakan satoshiotomakan commented Jul 3, 2024

Description

TON wallets currently use UQ format for their addresses, as the TON team mention they're more suitable for wallets.
Both EQ and UQ addresses work on the same way, but moving forward to the last one will empower to be more aligned with the latest technology in the network.

How to test

Run C++, Android, iOS tests

Types of changes

  • [BREAKING] AnyAddress.createWithPublicKey and other derive functions return non-bounceable address by default.
  • Add TONAddressConverter.toUserFriendly for the wallets that keeps using bounceable addresses.
  • Add StoredKey.updateAddress for the wallets to update TON address fro EQ to UQ format in the key storage.

Checklist

  • Create pull request as draft initially, unless its complete.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • If there is a related Issue, mention it in the description.

If you're adding a new blockchain

  • I have read the guidelines for adding a new blockchain.

Copy link

github-actions bot commented Jul 3, 2024

Binary size comparison

➡️ aarch64-apple-ios: 11.75 MB

➡️ aarch64-apple-ios-sim: 11.74 MB

➡️ aarch64-linux-android: 15.25 MB

➡️ armv7-linux-androideabi: 12.74 MB

➡️ wasm32-unknown-emscripten: 10.57 MB

@satoshiotomakan satoshiotomakan marked this pull request as draft July 3, 2024 12:08
@satoshiotomakan satoshiotomakan marked this pull request as ready for review July 4, 2024 11:38
@satoshiotomakan satoshiotomakan requested a review from gastonm5 July 4, 2024 13:02
Copy link

@gastonm5 gastonm5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@satoshiotomakan satoshiotomakan merged commit ca05821 into master Jul 4, 2024
13 checks passed
@satoshiotomakan satoshiotomakan deleted the s/ton-default-address-format branch July 4, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants