fix(derivation): Revert Derivation enum variants #3965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary size comparison➡️ aarch64-apple-ios: 11.99 MB ➡️ aarch64-apple-ios-sim: - 11.99 MB
+ 11.99 MB -1 KB➡️ aarch64-linux-android: - 15.34 MB
+ 15.34 MB -1 KB➡️ armv7-linux-androideabi: - 13.12 MB
+ 13.11 MB -1 KB➡️ wasm32-unknown-emscripten: - 10.86 MB
+ 10.86 MB -1 KB |
gastonm5
approved these changes
Aug 1, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The problem is that the derivation enum raw value is stored in KeyStore, and after the update we have a Derivation mismatch.
How to test
Run Rust, C++, Swift, Kotlin, JS tests
Types of changes
For example, TWDerivationSegwit is reverted back to TWDerivationLitecoinSegwit
Checklist
If you're adding a new blockchain