[TON] Support TON wallet V5R1 external signed message

[10gic]

Description

Support TON wallet V5R1.

There are three opcodes: signed_external, signed_internal, and extension_action. Currently, only signed_external is supported. It is sufficient for transferring native tokens, jettons, etc.

How to test

Run Rust, C++, iOS, Android tests

Types of changes

TON Breaking change:

1. Move Proto::Transfer::wallet_version to Proto::SigningInput::wallet_version, so the upstream code will also need to be adjusted accordingly.

Checklist

• Create pull request as draft initially, unless its complete.
• Add tests to cover changes as needed.
• Update documentation as needed.
• If there is a related Issue, mention it in the description.

If you're adding a new blockchain

• I have read the guidelines for adding a new blockchain.

[satoshiotomakan]

Hi @10gic, thank you for the extensive work! I'll do a proper PR review later this week 👍

[10gic]

Hi @10gic, thank you for the extensive work! I'll do a proper PR review later this week 👍

It's great to see this. I'm really looking forward to your comments.

[satoshiotomakan]

Hi @10gic, thanks again for the good quality PR! When I designed TonWallet structure, I didn't expect V5 will be so different. Please consider the suggestions to make it easier to add new versions in the future

[10gic]

Hi @10gic, thanks again for the good quality PR! When I designed TonWallet structure, I didn't expect V5 will be so different. Please consider the suggestions to make it easier to add new versions in the future

Thank you very much for your valuable comments. Except for this one (moving Proto::Transfer::wallet_version to Proto::SigningInput::wallet_version), which might involve a breaking change and hasn't been adjusted for now, I have accepted and made adjustments to all the others.

[10gic]

Hi @Vero7979. Thank you for recognizing my work. May I ask if you are from the trustwallet team?

[satoshiotomakan]

@10gic could you please resolve merge conflicts?

[satoshiotomakan]

One minor change please

[10gic]

@10gic could you please resolve merge conflicts?

Sure, I have rebased my branch.

[satoshiotomakan]

Great job!

[10gic]

Hi @Milerius @ar-g, I would greatly appreciate it if you could take the time to review this pull request.

[10gic]

The CI execution failed, and I am a bit curious why these issues didn't surface when I ran the script tools/build-and-test locally.

[satoshiotomakan]

@10gic, TWAnySignerTheOpenNetwork.SingMessageToTransferAndDeployWalletV5R1 C++ test has failed
Please note there are a few other tests need to be changed accordingly to the wallet_version change in Proto.
Android: https://github.com/trustwallet/wallet-core/blob/master/android/app/src/androidTest/java/com/trustwallet/core/app/blockchains/theopennetwork/TestTheOpenNetworkSigner.kt
iOS: https://github.com/trustwallet/wallet-core/blob/master/swift/Tests/Blockchains/TheOpenNetworkTests.swift
Wasm (JS): https://github.com/trustwallet/wallet-core/blob/master/wasm/tests/Blockchain/TheOpenNetwork.test.ts

[10gic]

@10gic, TWAnySignerTheOpenNetwork.SingMessageToTransferAndDeployWalletV5R1 C++ test has failed Please note there are a few other tests need to be changed accordingly to the wallet_version change in Proto. Android: https://github.com/trustwallet/wallet-core/blob/master/android/app/src/androidTest/java/com/trustwallet/core/app/blockchains/theopennetwork/TestTheOpenNetworkSigner.kt iOS: https://github.com/trustwallet/wallet-core/blob/master/swift/Tests/Blockchains/TheOpenNetworkTests.swift Wasm (JS): https://github.com/trustwallet/wallet-core/blob/master/wasm/tests/Blockchain/TheOpenNetwork.test.ts

Thank you so much. I will change it accordingly.

[satoshiotomakan]

Regarding tools/build-and-test script, it runs C++ tests only. Please re-run it, I guess something has been changed in the implementation, and the result Tx Cell should be updated.
For iOS, Android and Wasm tests, you can simply change the position of the wallet_version and push the changes, we can see the CI to pass. Though it's not difficult to configure Android, iOS, WASM environment, it still needs some time

[10gic]

Regarding tools/build-and-test script, it runs C++ tests only. Please re-run it, I guess something has been changed in the implementation, and the result Tx Cell should be updated. For iOS, Android and Wasm tests, you can simply change the position of the wallet_version and push the changes, we can see the CI to pass. Though it's not difficult to configure Android, iOS, WASM environment, it still needs some time

The failed Android/iOS/WASM test cases have been fixed, and tools/build-and-test was successful in my local environment. Could you help rerun the CI?

[10gic]

@10gic, TWAnySignerTheOpenNetwork.SingMessageToTransferAndDeployWalletV5R1 C++ test has failed Please note there are a few other tests need to be changed accordingly to the wallet_version change in Proto. Android: https://github.com/trustwallet/wallet-core/blob/master/android/app/src/androidTest/java/com/trustwallet/core/app/blockchains/theopennetwork/TestTheOpenNetworkSigner.kt iOS: https://github.com/trustwallet/wallet-core/blob/master/swift/Tests/Blockchains/TheOpenNetworkTests.swift Wasm (JS): https://github.com/trustwallet/wallet-core/blob/master/wasm/tests/Blockchain/TheOpenNetwork.test.ts

I have no idea why the case TWAnySignerTheOpenNetwork.SingMessageToTransferAndDeployWalletV5R1 would fail. I can run this case successfully in my local environment. Could you please help to rerun the CI so that I can check the log and gather more information for debugging?

[10gic]

@10gic, TWAnySignerTheOpenNetwork.SingMessageToTransferAndDeployWalletV5R1 C++ test has failed Please note there are a few other tests need to be changed accordingly to the wallet_version change in Proto. Android: https://github.com/trustwallet/wallet-core/blob/master/android/app/src/androidTest/java/com/trustwallet/core/app/blockchains/theopennetwork/TestTheOpenNetworkSigner.kt iOS: https://github.com/trustwallet/wallet-core/blob/master/swift/Tests/Blockchains/TheOpenNetworkTests.swift Wasm (JS): https://github.com/trustwallet/wallet-core/blob/master/wasm/tests/Blockchain/TheOpenNetwork.test.ts

I have no idea why the case TWAnySignerTheOpenNetwork.SingMessageToTransferAndDeployWalletV5R1 would fail. I can run this case successfully in my local environment. Could you please help to rerun the CI so that I can check the log and gather more information for debugging?

All checks have passed. It seems there is no issue with the test case.

[10gic]

I finally figured out why the test case TWAnySignerTheOpenNetwork.SingMessageToTransferAndDeployWalletV5R1 occasionally fails; see issue 4004.