[Security]: Generate random salt when creating/importing new wallet #4069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Milerius
approved these changes
Oct 17, 2024
Binary size comparison➡️ aarch64-apple-ios: 12.18 MB ➡️ aarch64-apple-ios-sim: 12.18 MB ➡️ aarch64-linux-android: 15.62 MB ➡️ armv7-linux-androideabi: 13.33 MB ➡️ wasm32-unknown-emscripten: 11.08 MB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Starting from Nov 23, 2021 at e110188, WalletCore always uses empty salt for PrivateKey/Mnemonic encryption.
This PR changes the behaviour to always generate random salt on creating/importing new wallets.
How to test
Run C++, iOS, Android tests
Types of changes
ScryptEncryption::Minimal,ScryptEncryption::Weak,ScryptEncryption::StandardconstantsScryptEncryption::minimal(),ScryptEncryption::weak(),ScryptEncryption::standard()constructors that always generate random saltChecklist
If you're adding a new blockchain