Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nimiq]: Add support for Nimiq PoS Albatross Mainnet #4115

Merged
merged 5 commits into from
Nov 18, 2024

Conversation

satoshiotomakan
Copy link
Collaborator

Description

Continues #4110

How to test

Run C++, iOS tests

Types of changes

Add SigningInput::network_id parameter.

Checklist

  • Create pull request as draft initially, unless its complete.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • If there is a related Issue, mention it in the description.

If you're adding a new blockchain

  • I have read the guidelines for adding a new blockchain.

Copy link

github-actions bot commented Nov 18, 2024

Binary size comparison

➡️ aarch64-apple-ios: 12.29 MB

➡️ aarch64-apple-ios-sim:

- 12.29 MB
+ 12.29 MB 	 +1 KB

➡️ aarch64-linux-android:

- 15.80 MB
+ 15.80 MB 	 +1 KB

➡️ armv7-linux-androideabi:

- 13.48 MB
+ 13.48 MB 	 +1 KB

➡️ wasm32-unknown-emscripten:

- 11.20 MB
+ 11.21 MB 	 +1 KB

@satoshiotomakan satoshiotomakan merged commit 45124dd into master Nov 18, 2024
13 checks passed
@satoshiotomakan satoshiotomakan deleted the s/nimiq-albatross branch November 18, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants