Modularize metrics adding check for voxels with no data inside of mask #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Is the goal to identify voxels with all zeroes inside the mask (in which case they should be outside the mask)? Voxels with all zeroes outside the mask should be fine, right? |
handwerkerd
changed the title
|
The goal is to identify voxels with zeroes inside the mask. I updated the title of this PR to correct my wording. |
tsalo
pushed a commit
that referenced
this pull request
Dec 13, 2019
Fit to each subset of echoes and fit to all data (not mean).
|
It should be good now, but if there's more work to do on this we should do it in the main repo since we now have this code located on a branch there instead of my fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on ME-ICA#475 .
Changes proposed in this pull request: