Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper handling of "default" #746

Closed
koppor opened this issue Jun 17, 2024 · 3 comments
Closed

Proper handling of "default" #746

koppor opened this issue Jun 17, 2024 · 3 comments

Comments

@koppor
Copy link

koppor commented Jun 17, 2024

I got another "interesting" pull request: JabRef/jabref#11282.

I think, RefactoringMiner does not properly handle "default". Without any change in the letters, it is marked as removed and added:

image


Side note (not related to the issue itself, but to the linked pull request): In general, my wish is "endless scrolling" and not only synchronized scrolling as requested at #672

@tsantalis
Copy link
Owner

@koppor
Thank you for reporting the issue.

@pouryafard75
It seems we do not process the default keyword.

@tsantalis
Copy link
Owner

tsantalis commented Jun 17, 2024

@koppor
We are currently working on the feature to hide the unchanged parts of the code, similar to GitHub.

The endless scrolling feature will be the next one to implement.
For the moment, we added two buttons Prev and Next to go directly to the next diff, without going back to the main page listing all diffs.

@tsantalis
Copy link
Owner

@koppor

We also improved the diff of formatting changes in Javadoc.

image

tsantalis added a commit that referenced this issue Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants