Update dependencies and always return a promise

tschaub · Jan 20, 2023 · e1374b3 · e1374b3
1 parent fc04b25
commit e1374b3
Show file tree

Hide file tree

Showing 5 changed files with 615 additions and 408 deletions.
diff --git a/lib/index.js b/lib/index.js
@@ -53,7 +53,7 @@ exports.defaults = {
 /**
  * Push a git branch to a remote (pushes gh-pages by default).
  * @param {string} basePath The base path.
- * @param {Object} config Publish options.
+ * @param {object} config Publish options.
  * @param {Function} callback Callback.
  * @return {Promise} A promise.
  */
@@ -88,12 +88,13 @@ exports.publish = function publish(basePath, config, callback) {
 
   try {
     if (!fs.statSync(basePath).isDirectory()) {
-      done(new Error('The "base" option must be an existing directory'));
-      return;
+      const err = new Error('The "base" option must be an existing directory');
+      done(err);
+      return Promise.reject(err);
     }
   } catch (err) {
     done(err);
-    return;
+    return Promise.reject(err);
   }
 
   const files = globby

diff --git a/lib/util.js b/lib/util.js
@@ -70,7 +70,7 @@ exports.dirsToCreate = dirsToCreate;
 
 /**
  * Copy a file.
- * @param {Object} obj Object with src and dest properties.
+ * @param {object} obj Object with src and dest properties.
  * @param {function(Error)} callback Callback
  */
 function copyFile(obj, callback) {