Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AppleWWDRCA certificate to G4 #132

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

soukicz
Copy link
Contributor

@soukicz soukicz commented Jul 27, 2023

Only the G4 certificate is valid for signing passes with certificates generated after the 27th of January, 2022 - https://pkpassvalidator.azurewebsites.net/

@tschoffelen
Copy link
Owner

Thanks for opening this PR, really appreciate your contribution!

This new root certificate might possibly not work with older pass certificates generated before that date, so if we release this, it would be a breaking version update (i.e. major version in semver).

Alternatively, should we encourage people to set their own WWDR certificate by better documenting the open setWwdrCertificatePath() and over time deprecating the default included certificate?

@razvanphp
Copy link

razvanphp commented Dec 15, 2023

I can confirm that this is the right updated certificate for passes, not sure how it works for people on master since #119 was merged...

The old passes signed with the old certificate still work, it's just about NEW passes that needs to be signed with the new one, so we can upgrade the certificate at any time.

Copy link
Owner

@tschoffelen tschoffelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change!

@tschoffelen tschoffelen merged commit 06ce23c into tschoffelen:master Dec 15, 2023
@tschoffelen
Copy link
Owner

Released to Packagist as version 2.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants