Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python memory leak #193

Merged
merged 1 commit into from
Feb 13, 2022
Merged

Fix python memory leak #193

merged 1 commit into from
Feb 13, 2022

Conversation

tschoonj
Copy link
Owner

Closes #192

@tschoonj
Copy link
Owner Author

@djvine the fix in this PR seems to fix the memory leak for me. Can you confirm this?

@djvine
Copy link

djvine commented Feb 12, 2022

PR fixes the memory leak.

Thanks!

@tschoonj
Copy link
Owner Author

Many thanks for confirming that this PR fixes the issue. I will try and make a new release as soon as possible.

By the way, if your company continues to use xraylib, it would be great if you could consider sponsoring me to keep me incentivised to keep working on it.

@tschoonj tschoonj merged commit 72993f3 into master Feb 13, 2022
@uvainio
Copy link

uvainio commented Feb 13, 2022

Tom, unfortunately it's difficult for companies to sponsor anything due to various regulations and complications. It's easier for example to buy consulting for a specific task. Unfortunately.

@tschoonj
Copy link
Owner Author

Tom, unfortunately it's difficult for companies to sponsor anything due to various regulations and complications. It's easier for example to buy consulting for a specific task. Unfortunately.

This may be true for Hitachi, but is certainly not true in general. I am not sure why this would need be done through consulting: I would argue that sponsoring an open-source project is similar to paying for licenses of commercial software packages.

After my departure from the X-ray spectroscopy community, xraylib has now become a Sunday afternoon hobby project with a bus-factor of 1. While I am happy that xraylib is extensively used throughout industry, I would consider it to be rather risky for anyone there to continue using it for anything that can be considered as business critical, as you are basically pinning your hopes on myself continuing to develop and maintain it, unpaid, while sacrificing precious spare time that I could/should be spending with my wife and son.

For example, finding and fixing the bug that was reported by @djvine, followed by making the new release took about 5 hours out of my weekend, and I do very much like my weekends 😏

@djvine
Copy link

djvine commented Feb 13, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python memory leak
3 participants