18536 Fixed lint warnings before further development (bcgov#581)

* - app version = 5.6.0 - fixed a whack of lint warnings * - imported CorpTypeCd directly from module to avoid type confusion
tshyun24 · Nov 16, 2023 · 700a8b4 · 700a8b4
1 parent 909a18c
commit 700a8b4
Show file tree

Hide file tree

Showing 51 changed files with 185 additions and 201 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "business-create-ui",
-  "version": "5.5.8",
+  "version": "5.6.0",
   "private": true,
   "appName": "Create UI",
   "sbcName": "SBC Common Components",

diff --git a/src/components/Dissolution/CompleteResolution.vue b/src/components/Dissolution/CompleteResolution.vue
@@ -63,8 +63,8 @@
           </header>
 
           <span
-            v-for="(item, index) in getCreateResolutionResource.helpSection.helpText.section1.items"
-            :key="index"
+            v-for="(item, index1) in getCreateResolutionResource.helpSection.helpText.section1.items"
+            :key="index1"
           >
             <p
               v-if="item.type === ItemTypes.TEXT"
@@ -74,8 +74,8 @@
             <v-row v-if="item.type === ItemTypes.PARTIAL_ITEMS">
               <v-col cols="11">
                 <span
-                  v-for="(partialItem, index) in item.value"
-                  :key="index"
+                  v-for="(partialItem, index2) in item.value"
+                  :key="index2"
                 >
                   <span
                     v-if="partialItem.type === ItemTypes.TEXT"
@@ -426,8 +426,8 @@
             </v-checkbox>
             <ul>
               <li
-                v-for="(item, index) in getCreateResolutionResource.confirmSection.items"
-                :key="index"
+                v-for="(item, index1) in getCreateResolutionResource.confirmSection.items"
+                :key="index1"
                 class="mt-4"
               >
                 <v-row
@@ -450,8 +450,8 @@
                   </v-col>
                   <v-col cols="11">
                     <span
-                      v-for="(partialItem, index) in item.value"
-                      :key="index"
+                      v-for="(partialItem, index2) in item.value"
+                      :key="index2"
                     >
                       <span
                         v-if="partialItem.type === ItemTypes.TEXT"
@@ -846,7 +846,7 @@ export default class CompleteResolution extends Mixins(CommonMixin, DateMixin) {
   // v-observe-visibility property, we are able to force a re-calculation of the text area height when a user navigates
   // to the complete resolution step from another step for the first time. This results in the text area being rendered
   // to the appropriate height.
-  onResolutionVisibilityChanged (isVisible: boolean, _entry): void {
+  onResolutionVisibilityChanged (isVisible: boolean): void {
     if (isVisible) {
       this.$refs.resolutionTextRef.calculateInputHeight()
     }

diff --git a/src/components/Dissolution/CompleteResolutionSummary.vue b/src/components/Dissolution/CompleteResolutionSummary.vue
@@ -242,7 +242,7 @@ export default class CompleteResolutionSummary extends Mixins(DateMixin) {
   // v-observe-visibility property, we are able to force a re-calculation of the text area height when a user navigates
   // to the complete resolution summary step from another step for the first time. This results in the text area being
   // rendered to the appropriate height.
-  onResolutionVisibilityChanged (isVisible: boolean, _entry): void {
+  onResolutionVisibilityChanged (isVisible: boolean): void {
     if (isVisible && this.resolutionTextHeightUpdateRequired) {
       this.resolutionTextHeightUpdateRequired = false
       this.$refs.resolutionTextRef.calculateInputHeight()

diff --git a/src/components/Incorporation/IncorporationDateTime.vue b/src/components/Incorporation/IncorporationDateTime.vue
@@ -340,7 +340,7 @@ export default class IncorporationDateTime extends Mixins(DateMixin) {
    * @param val The date input
    */
   @Watch('dateText')
-  private onEffectiveDateManual (val: string): void {
+  private onEffectiveDateManual (): void {
     this.constructDate()
   }
 
@@ -349,7 +349,7 @@ export default class IncorporationDateTime extends Mixins(DateMixin) {
    * @param val The hour selected
    */
   @Watch('selectHour')
-  private onHourUpdate (val: string): void {
+  private onHourUpdate (): void {
     this.constructDate()
   }
 
@@ -358,7 +358,7 @@ export default class IncorporationDateTime extends Mixins(DateMixin) {
    * @param val The minute selected
    */
   @Watch('selectMinute')
-  private onMinuteUpdate (val: string): void {
+  private onMinuteUpdate (): void {
     this.constructDate()
   }
 
@@ -367,7 +367,7 @@ export default class IncorporationDateTime extends Mixins(DateMixin) {
    * @param val The time period selected
    */
   @Watch('selectPeriod')
-  private onPeriodUpdate (val: string): void {
+  private onPeriodUpdate (): void {
     this.constructDate()
   }
 
@@ -376,8 +376,8 @@ export default class IncorporationDateTime extends Mixins(DateMixin) {
    * @param val The value of the selected radio button
    */
   @Watch('selectDate')
-  private setDateTimeChoice (val) {
-    this.isFutureEffective = val === ISFUTUREEFFECTIVE
+  private setDateTimeChoice (val: string) {
+    this.isFutureEffective = (val === ISFUTUREEFFECTIVE)
     this.isImmediate = !this.isFutureEffective
 
     // Clear DateTimes when immediate is selected

diff --git a/src/components/Incorporation/ShareStructure.vue b/src/components/Incorporation/ShareStructure.vue
@@ -387,15 +387,19 @@ export default class ShareStructure extends Mixins(CurrencyLookupMixin) {
 
   // Events
   @Emit('addEditClass')
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   private emitAddEditShareClassEvent (shareClass: ShareClassIF): void {}
 
   @Emit('addEditSeries')
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   private emitAddEditShareSeriesEvent (shareSeries: ShareClassIF): void {}
 
   @Emit('removeClass')
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   private emitRemoveShareClassEvent (shareClassIndex: number): void {}
 
   @Emit('removeSeries')
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   private emitRemoveShareSeriesEvent (parentIndex: number, shareSeriesIndex: number): void {}
 
   @Emit('resetEvent')

diff --git a/src/components/Incorporation/UploadRules.vue b/src/components/Incorporation/UploadRules.vue
@@ -74,23 +74,23 @@
           </p>
           <ul class="bulleted-list mt-4">
             <li
-              v-for="(item, index) in getCreateRulesResource.helpSection.helpText.section2.items"
-              :key="index"
+              v-for="(item, index1) in getCreateRulesResource.helpSection.helpText.section2.items"
+              :key="index1"
             >
               <span
                 v-if="item.type === ItemTypes.TEXT"
                 v-html="item.value"
               />
               <template v-if="item.type === ItemTypes.PARTIAL_ITEMS">
-                <template v-for="(partialItem, index) in item.value">
+                <template v-for="(partialItem, index2) in item.value">
                   <span
                     v-if="partialItem.type === ItemTypes.TEXT"
-                    :key="index"
+                    :key="index2"
                     v-html="partialItem.value"
                   />
                   <a
                     v-if="partialItem.type === ItemTypes.LINK"
-                    :key="index"
+                    :key="index2"
                     :href="partialItem.value.href"
                     target="_blank"
                   >

diff --git a/src/components/Restoration/BusinessName.vue b/src/components/Restoration/BusinessName.vue
@@ -91,7 +91,7 @@ export default class BusinessName extends Mixins(CommonMixin, DateMixin, NameReq
   // Global actions
   @Action(useStore) setBusinessNameValid!: (x: boolean) => void
   @Action(useStore) setCorrectNameOption!: (x: CorrectNameOptions) => void
-  @Action(useStore) setNameRequest!: (x: string) => void
+  @Action(useStore) setNameRequest!: (x: NameRequestIF) => void
   @Action(useStore) setNameRequestApprovedName!: (x: string) => void
 
   // Local variable
@@ -180,7 +180,7 @@ export default class BusinessName extends Mixins(CommonMixin, DateMixin, NameReq
 
   /** Updates component validity initially and when correct name option has changed. */
   @Watch('getCorrectNameOption', { immediate: true })
-  private updateComponentValidity (val: boolean): void {
+  private updateComponentValidity (): void {
     this.setBusinessNameValid(!!this.getCorrectNameOption)
   }
 }

diff --git a/src/components/common/ListPeopleAndRoles.vue b/src/components/common/ListPeopleAndRoles.vue
@@ -56,8 +56,8 @@
 
         <!-- List Content -->
         <v-row
-          v-for="(orgPerson, index) in personList"
-          :key="index"
+          v-for="(orgPerson, index1) in personList"
+          :key="index1"
           class="people-roles-content"
           no-gutters
         >
@@ -124,8 +124,8 @@
             class="roles-column"
           >
             <p
-              v-for="(role, index) in orgPerson.roles"
-              :key="index"
+              v-for="(role, index2) in orgPerson.roles"
+              :key="index2"
             >
               {{ role.roleType }}
             </p>
@@ -149,11 +149,11 @@
             <div class="float-right">
               <span class="edit-action">
                 <v-btn
-                  :id="`officer-${index}-change-btn`"
+                  :id="`officer-${index1}-change-btn`"
                   text
                   color="primary"
                   :tabindex="disabled ? -1 : 0"
-                  @click="disabled ? null : emitPersonInfo(index)"
+                  @click="disabled ? null : emitPersonInfo(index1)"
                 >
                   <v-icon small>mdi-pencil</v-icon>
                   <span>Edit</span>
@@ -180,7 +180,7 @@
                     </v-btn>
                   </template>
                   <v-list class="more-actions-list">
-                    <v-list-item @click="emitRemovePerson(index)">
+                    <v-list-item @click="emitRemovePerson(index1)">
                       <v-list-item-title>
                         <v-icon
                           small

diff --git a/src/components/common/OfficeAddresses.vue b/src/components/common/OfficeAddresses.vue
@@ -616,7 +616,7 @@ export default class OfficeAddresses extends Mixins(CommonMixin) {
 
   // Watchers
   @Watch('formValid')
-  private onFormValidityChange (val: boolean): void {
+  private onFormValidityChange (): void {
     this.emitValid()
   }
 

diff --git a/src/components/common/RegAddEditOrgPerson.vue b/src/components/common/RegAddEditOrgPerson.vue
@@ -79,8 +79,8 @@
                   class="item first-name"
                   label="First Name"
                   :rules="enableRules ?
-                   (isCompletingParty ? Rules.FirstNameRulesFirmsCP :
-                   Rules.FirstNameRulesFirms) : []"
+                    (isCompletingParty ? Rules.FirstNameRulesFirmsCP :
+                      Rules.FirstNameRulesFirms) : []"
                   :readonly="isCompletingParty && !(isRoleStaff || isSbcStaff)"
                 />
                 <v-text-field

diff --git a/src/dialogs/FilingSurveyDialog.vue b/src/dialogs/FilingSurveyDialog.vue
@@ -80,6 +80,7 @@ export default class FilingSurveyDialog extends Vue {
   // Pass events to parent.
   @Emit() no (): void {}
   @Emit() yes (): void {}
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   @Emit('doNotShow') doNotShow (val: boolean): void {}
 }
 </script>

diff --git a/src/interfaces/filing-interfaces/filing-data-interface.ts b/src/interfaces/filing-interfaces/filing-data-interface.ts
@@ -1,5 +1,5 @@
 import { FilingCodes } from '@/enums'
-import { CorpTypeCd } from '@bcrs-shared-components/enums/'
+import { CorpTypeCd } from '@bcrs-shared-components/corp-type-module/'
 
 /** Filing data for SBC Fee Summary component. */
 export interface FilingDataIF {

diff --git a/src/interfaces/filing-interfaces/filing-interfaces.ts b/src/interfaces/filing-interfaces/filing-interfaces.ts
@@ -2,7 +2,8 @@ import { BusinessAddressIF, CourtOrderIF, RegisteredRecordsAddressesIF, NaicsIF,
   OfficeAddressIF, PartyIF, ShareClassIF, SpecialResolutionIF } from '@/interfaces'
 import { ApprovalTypes, BusinessTypes, DissolutionStatementTypes, DissolutionTypes, FilingTypes,
   RestorationTypes, RelationshipTypes } from '@/enums'
-import { CorpTypeCd, CorrectNameOptions } from '@bcrs-shared-components/enums/'
+import { CorrectNameOptions } from '@bcrs-shared-components/enums/'
+import { CorpTypeCd } from '@bcrs-shared-components/corp-type-module/'
 import { ContactPointIF } from '@bcrs-shared-components/interfaces'
 
 /**
@@ -78,7 +79,7 @@ export interface IncorporationFilingIF {
 /** Interface for registration filing data saved to the Legal API. */
 export interface RegistrationFilingIF {
   header: {
-    name: string
+    name: FilingTypes
     certifiedBy: string
     date: string
     effectiveDate?: string // not saved by UI but may be provided by API
@@ -118,7 +119,7 @@ export interface RegistrationFilingIF {
 /** Interface for dissolution filing data saved to the Legal API. */
 export interface DissolutionFilingIF {
   header: {
-    name: string
+    name: FilingTypes
     certifiedBy: string
     date: string
     effectiveDate?: string // Optional and should be set only for future effective filings
@@ -168,7 +169,7 @@ export interface DissolutionFilingIF {
 /** Interface for restoration filing data saved to the Legal API. */
 export interface RestorationFilingIF {
   header: {
-    name: string
+    name: FilingTypes
     certifiedBy: string
     date: string
     effectiveDate?: string // not saved by UI but may be provided by API

diff --git a/src/interfaces/resource-interfaces/resource-interface.ts b/src/interfaces/resource-interfaces/resource-interface.ts
@@ -3,7 +3,7 @@ import {
   PeopleAndRolesResourceIF, StepIF, CreateRulesResourceIF, CreateMemorandumResourceIF,
   CreateResolutionResourceIF, CustodianResourceIF, CompletingPartyStatementIF
 } from '@/interfaces'
-import { CorpTypeCd } from '@bcrs-shared-components/enums/'
+import { CorpTypeCd } from '@bcrs-shared-components/corp-type-module'
 
 /** Dissolution resource interface. */
 export interface DissolutionResourceIF {

diff --git a/src/interfaces/store-interfaces/state-interface.ts b/src/interfaces/store-interfaces/state-interface.ts
@@ -1,4 +1,5 @@
-import { CorpTypeCd, CorrectNameOptions } from '@bcrs-shared-components/enums/'
+import { CorrectNameOptions } from '@bcrs-shared-components/enums/'
+import { CorpTypeCd } from '@bcrs-shared-components/corp-type-module'
 import {
   AccountInformationIF,
   ContactPointIF,

diff --git a/src/mixins/filing-template-mixin.ts b/src/mixins/filing-template-mixin.ts
@@ -14,7 +14,8 @@ import {
 import { ApprovalTypes, BusinessTypes, CoopTypes, DissolutionTypes, EffectOfOrders, FilingTypes,
   PartyTypes, RelationshipTypes, RestorationTypes, RoleTypes, StaffPaymentOptions
 } from '@/enums'
-import { CorpTypeCd, CorrectNameOptions } from '@bcrs-shared-components/enums/'
+import { CorrectNameOptions } from '@bcrs-shared-components/enums/'
+import { CorpTypeCd } from '@bcrs-shared-components/corp-type-module/'
 
 /**
  * Mixin that provides the integration with the Legal API.

diff --git a/src/resources/BreadCrumbResource.ts b/src/resources/BreadCrumbResource.ts
@@ -1,9 +1,8 @@
 import { FilingTypes } from '@/enums'
-import { CorpTypeCd } from '@bcrs-shared-components/enums/'
+import { GetCorpNumberedDescription } from '@bcrs-shared-components/corp-type-module'
 import { BreadcrumbIF } from '@/interfaces'
 import { createPinia, setActivePinia } from 'pinia'
 import { useStore } from '@/store/store'
-import { GetCorpNumberedDescription } from '@bcrs-shared-components/corp-type-module'
 
 setActivePinia(createPinia())
 const store = useStore()
@@ -24,7 +23,7 @@ function getLegalName (): string {
 
 /** Returns numbered entity name. */
 function getNumberedEntityName (): string {
-  const getEntityType = store.getEntityType as CorpTypeCd
+  const getEntityType = store.getEntityType
   return GetCorpNumberedDescription(getEntityType)
 }
 

diff --git a/src/resources/Dissolution/BC.ts b/src/resources/Dissolution/BC.ts
@@ -1,7 +1,6 @@
 import { DissolutionResourceIF } from '@/interfaces'
 import { BulletListTypes, FilingCodes, ItemTypes } from '@/enums'
-import { CorpTypeCd } from '@bcrs-shared-components/enums/'
-import { GetCorpFullDescription } from '@bcrs-shared-components/corp-type-module'
+import { CorpTypeCd, GetCorpFullDescription } from '@bcrs-shared-components/corp-type-module'
 import { DissolutionStepsCorp } from './steps'
 
 export const DissolutionResourceBc: DissolutionResourceIF = {

diff --git a/src/resources/Dissolution/BEN.ts b/src/resources/Dissolution/BEN.ts
@@ -1,7 +1,6 @@
 import { DissolutionResourceIF } from '@/interfaces'
 import { BulletListTypes, FilingCodes, ItemTypes } from '@/enums'
-import { CorpTypeCd } from '@bcrs-shared-components/enums/'
-import { GetCorpFullDescription } from '@bcrs-shared-components/corp-type-module'
+import { CorpTypeCd, GetCorpFullDescription } from '@bcrs-shared-components/corp-type-module'
 import { DissolutionStepsCorp } from './steps'
 
 export const DissolutionResourceBen: DissolutionResourceIF = {

diff --git a/src/resources/Dissolution/CC.ts b/src/resources/Dissolution/CC.ts
@@ -1,7 +1,6 @@
 import { DissolutionResourceIF } from '@/interfaces'
 import { BulletListTypes, FilingCodes, ItemTypes } from '@/enums'
-import { CorpTypeCd } from '@bcrs-shared-components/enums/'
-import { GetCorpFullDescription } from '@bcrs-shared-components/corp-type-module'
+import { CorpTypeCd, GetCorpFullDescription } from '@bcrs-shared-components/corp-type-module'
 import { DissolutionStepsCorp } from './steps'
 
 export const DissolutionResourceCc: DissolutionResourceIF = {

diff --git a/src/resources/Dissolution/CP.ts b/src/resources/Dissolution/CP.ts
@@ -1,7 +1,6 @@
 import { DissolutionResourceIF } from '@/interfaces'
 import { BulletListTypes, DissolutionStatementTypes, FilingCodes, ItemTypes } from '@/enums'
-import { CorpTypeCd } from '@bcrs-shared-components/enums/'
-import { GetCorpFullDescription } from '@bcrs-shared-components/corp-type-module'
+import { CorpTypeCd, GetCorpFullDescription } from '@bcrs-shared-components/corp-type-module'
 import { DissolutionStepsCoop } from './steps'
 
 export const DissolutionResourceCp: DissolutionResourceIF = {