packer: Fix possible array indexing error when pixels is null #54
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saw this bug while watching the stream on YT. The bug is that
pixels
is indexed before the null check and that could result in a fatal error in case of a null value. The null check is done a little bit late.koil/packer.c3
Lines 24 to 32 in 48d0f0d
What I did
Moved the lines for getting the offset, size, appending to assets and appending pixels to the pack to run after the null check.