Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for FFNx 1.8+ #1

Merged
merged 21 commits into from
Jan 24, 2021
Merged

Add support for FFNx 1.8+ #1

merged 21 commits into from
Jan 24, 2021

Conversation

julianxhokaxhiu
Copy link
Member

@julianxhokaxhiu julianxhokaxhiu commented Jan 23, 2021

This PR will add all the required patches to ensure it can support any version of FFNx starting 1,8 and ongoing, and it contains:

  • Built-in Update mechanism to download and extract the latest Stable/Canary version available on Github on the chosen FF7.exe game path
  • Built-it auto-download of the latest Stable version on a fresh install ( Game Driver will no more be pre-packaged )
  • Reworked Game Driver configuration panel. It adds support for the new flags, it now supports natively the TOML language and it replaces ONLY the flag known to 7th. The flags that does not know, will be preserved. This will allow some hybrid manual/auto configuration.
  • Adds to the default monitoring path list sfx and voice

Not related to the PR itself, but still useful to have, in addition to all of that it also adds:

  • Ability for Mods to use multiple paths for lookup not only for default folders in data but also for the ones watched. This will allow for example the Bonez SFX mod the way it is organized today to spread not only SFX files, but also Music files on top of different folders. This will allow mods to be much slimmer in size, yet powerful in configuration.
  • The project has no more Git Submodules but uses the Visual Studio NuGet dependency manager for third-party libraries
  • The overall solution has been upgraded from .NET 4.5 to 4.8

This PR lacks translation for the various languages. Some shown text is hardcoded in code, some other is just left in English on the relative XML files. Anyone is welcome to translate those after this PR has been merged.

A CI is going to be added once this PR will be merged.

IMPORTANT: In order to test the Game Driver configuration window you MUST download the latest canary for now, as the Stable lacks some minor but important changes in the default FFNx.toml file which is uncommented default flags.

This commit will:
- Add a new section in the General Settings window
- Allow the user to choose between multiple FFNx release channels
- Allow the user to manually check for updates and install/replace the current installed version ( if newer or older than the currently installed )
Preserve manual edited flags and override only the ones configured via GUI
This commit will switch to the Browse panel because it contains the download widget, which will contain our FFNx release download progress.
Once the download and the extraction is completed successfully, it will switch back to the Mods panel. Purely a workaround for a poor Download UX concept.
@julianxhokaxhiu julianxhokaxhiu self-assigned this Jan 23, 2021
@julianxhokaxhiu julianxhokaxhiu added the enhancement New feature or request label Jan 23, 2021
@barkermn01
Copy link
Member

@julianxhokaxhiu is there an example of how a mod could do the new multi-folder thing as per,
"Ability for Mods to use multiple paths for lookup not only for default folders in data but also for the ones watched. This will allow for example the Bonez SFX mod the way it is organized today to spread not only SFX files but also Music files on top of different folders. This will allow mods to be much slimmer in size, yet powerful in the configuration."

Just so it can be added to readme and instruction documents as required?

@barkermn01 barkermn01 merged commit cb434a7 into develop Jan 24, 2021
@barkermn01
Copy link
Member

Just a note this has been Squashed and merged so it's one commit to Develop branch.

@julianxhokaxhiu julianxhokaxhiu deleted the feature/FFNx-1.8 branch January 24, 2021 15:33
@julianxhokaxhiu
Copy link
Member Author

Just so it can be added to readme and instruction documents as required?

This feature is already documented here: https://7thheaven.rocks/help/modhelp.html#modfolders

All I did was adding support for monitored folders too, and not only limiting this to data/* folders.

Thanks for the merge :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants