UI: Tweak driver upgrade/downgrade message #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ding/downgrading FFNx We get this question often enough, and Kuraudo asked nicely...
julianxhokaxhiu
requested changes
Oct 1, 2023
There was a problem hiding this comment.
Thanks for the PR :) Despite the good intentions there I'd like to have a bit more professional message and if possible added here instead which is the last message the user will see after FFNx has been updated: https://github.com/tsunamods-codes/7th-Heaven/blob/master/SeventhHeavenUI/Classes/FFNxDriverUpdater.cs#L261
Also I think something like "Settings have been reset to default" is enough to let the users know about this. No need to add any hint or pointer to reconfigure them, they'll understand it.
If you can please rework your PR, I'll be happy to review. Thanks!
|
Moved over to where you suggested |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remind users to reconfigure their driver after upgrading/downgrading FFNx. We get this question often enough, and Kuraudo asked nicely...