Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UpdateChecker: Use the installer to auto-update #153

Merged
merged 2 commits into from
Nov 19, 2023
Merged

UpdateChecker: Use the installer to auto-update #153

merged 2 commits into from
Nov 19, 2023

Conversation

julianxhokaxhiu
Copy link
Member

@julianxhokaxhiu julianxhokaxhiu commented Nov 19, 2023 •
edited
Loading

Starting this PR we will use the EXE installer instead of the ZIP release to manage upgrades.

This will allow us to scale better in future even when the stacks are bumped.

The user behavior remains basically the same:

  1. 7thHeaven downloads the EXE
  2. It will run it in silent mode
  • If missing dependencies are not installed the installer will prompt the user to install them
  • if dependencies are met it will continue the installation as usual on the path where 7th is currently being run
  1. It will automatically restart 7th Heaven after the upgrade

@julianxhokaxhiu julianxhokaxhiu added the enhancement New feature or request label Nov 19, 2023
@julianxhokaxhiu julianxhokaxhiu self-assigned this Nov 19, 2023
@julianxhokaxhiu julianxhokaxhiu added the priority/P1 likely to affect end users label Nov 19, 2023
@julianxhokaxhiu julianxhokaxhiu force-pushed the feat/refine-updater branch 2 times, most recently from a05af49 to 2f619ad Compare November 19, 2023 14:47
@julianxhokaxhiu julianxhokaxhiu changed the title UpdateChecker: Do not upgrade on certain cases UpdateChecker: Use the installer to auto-update Nov 19, 2023
@julianxhokaxhiu julianxhokaxhiu force-pushed the feat/refine-updater branch 3 times, most recently from 96cef18 to 237ba12 Compare November 19, 2023 15:49
@julianxhokaxhiu
UpdateChecker: Use the installer to auto-update
068c3ae 
This approach will allow us to scale better with future releases as it will take care of managing dependencies
tangtang95
tangtang95 approved these changes Nov 19, 2023
View reviewed changes
Copy link
Collaborator

@tangtang95 tangtang95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julianxhokaxhiu julianxhokaxhiu merged commit a45533f into master Nov 19, 2023
1 check passed
@julianxhokaxhiu julianxhokaxhiu deleted the feat/refine-updater branch November 19, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangtang95 tangtang95 tangtang95 approved these changes

Assignees

@julianxhokaxhiu julianxhokaxhiu

Labels
enhancement New feature or request priority/P1 likely to affect end users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julianxhokaxhiu @tangtang95