Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SeventhHeavenUI: Remove 8x/16x MSAA as selectable options #176

Merged
merged 1 commit into from
Jan 28, 2024
Merged

Conversation

eve-atum
Copy link

Cranking MSAA too high causes visual artifacts on 4k screens, and increases the likelihood of bgfx device disconnects on older GPU hardware.

@julianxhokaxhiu
Copy link
Member

What about people with more capable GPUs that can actually make use of the 8x/16x modes? Why preclude to them this ability? Our platform is meant for modern GPUs, so this change goes completely against this.

@eve-atum
Copy link
Author

Too high an MSAA will still mess with 4k screens, and there's nothing stopping folks from manually tweaking their toml

Raising MSAA too high causes visual artifacts on 4k screens, and increases likelihood of bgfx device disconnects on older GPU hardware
@julianxhokaxhiu julianxhokaxhiu added enhancement New feature or request priority/P1 likely to affect end users labels Jan 28, 2024
@julianxhokaxhiu julianxhokaxhiu changed the title Remove 8x and 16x MSAA as selectable options SeventhHeavenUI: Remove 8x/16x MSAA as selectable options Jan 28, 2024
@julianxhokaxhiu julianxhokaxhiu merged commit 11aa677 into tsunamods-codes:master Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority/P1 likely to affect end users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants