Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Front Facing API #8

Draft
wants to merge 18 commits into
base: develop
Choose a base branch
from
Draft

Front Facing API #8

wants to merge 18 commits into from

Conversation

ttocsneb
Copy link
Owner

@ttocsneb ttocsneb commented Apr 3, 2024

This is the implementation for #5.

This change includes the following:

  • Item Structure
  • Serde Implementation
  • Engine Structure

tryoxiss
tryoxiss requested changes Apr 5, 2024
View reviewed changes
Copy link
Collaborator

@tryoxiss tryoxiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good, however you forgot to add specific details in the MIT. Its not needed in the apache (I dont know if they want you to do it) because its not part of the licence deed, its just a footnote, but its defintely what people do with the MIT.

LICENSE-MIT Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tryoxiss tryoxiss tryoxiss requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ttocsneb @tryoxiss