-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Less Ambiguous Wind Direction Arrows #126
[Enhancement] Less Ambiguous Wind Direction Arrows #126
Conversation
d4b3e64
to
6829387
Compare
Hey @kevinmatthes, thanks for the PR. My schedule just gives me some free minutes at nighttime atm. I'm looking into it soon. Sorry for the delay |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This introduced a not-uniform style to the arrows.
Would it be a hindrance to use them as fallback characters related to your suggestion in #121?
Thank you for your review, @tobealive! The style depends on the used font; your system seems to try to map the Unicode arrows to the emojis. In my GitHub change view, the changes are from tofu to a displayable arrow in each case and all arrows are of the same size, just rotated. Please try what happens when you run the changes in a terminal, or just If it should still does not look uniform, I will withdraw this PR and submit a new one where the Unicode arrows are the fallback solution to the emojis. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for the contribution @kevinmatthes!
Solved missing arrows on OSX 🎉🙏 |
This PR is related to #121 and applies less ambiguous wind direction arrows. Despite also having emojis for arrows, there are furthermore some characters available which are natural part of the default keyboard layouts of Linux systems. These arrows are known to be less ambiguous than the emoji arrows, which are sometimes rendered as Asian characters, due to having lower UTF-8 character codes.
(Drafted due to the typo in the commit message: "ambigous".)