Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Less Ambiguous Wind Direction Arrows #126

Merged

Conversation

kevinmatthes
Copy link
Collaborator

This PR is related to #121 and applies less ambiguous wind direction arrows. Despite also having emojis for arrows, there are furthermore some characters available which are natural part of the default keyboard layouts of Linux systems. These arrows are known to be less ambiguous than the emoji arrows, which are sometimes rendered as Asian characters, due to having lower UTF-8 character codes.

(Drafted due to the typo in the commit message: "ambigous".)

@kevinmatthes kevinmatthes marked this pull request as draft April 30, 2023 17:21
@kevinmatthes kevinmatthes force-pushed the feature/less-ambigous-wind-direction-arrows branch from d4b3e64 to 6829387 Compare April 30, 2023 17:23
@kevinmatthes kevinmatthes marked this pull request as ready for review April 30, 2023 17:24
@github-actions
Copy link

Test Results

  3 files  ±0    3 suites  ±0   4s ⏱️ -1s
  9 tests ±0    9 ✔️ ±0  0 💤 ±0  0 ±0 
27 runs  ±0  27 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 6829387. ± Comparison against base commit 43a0e36.

@ttytm
Copy link
Owner

ttytm commented May 3, 2023

Hey @kevinmatthes,

thanks for the PR. My schedule just gives me some free minutes at nighttime atm. I'm looking into it soon. Sorry for the delay

Copy link
Owner

@ttytm ttytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot_20230506_165311

This introduced a not-uniform style to the arrows.
Would it be a hindrance to use them as fallback characters related to your suggestion in #121?

@kevinmatthes
Copy link
Collaborator Author

Thank you for your review, @tobealive!

The style depends on the used font; your system seems to try to map the Unicode arrows to the emojis. In my GitHub change view, the changes are from tofu to a displayable arrow in each case and all arrows are of the same size, just rotated.

Please try what happens when you run the changes in a terminal, or just cat both states. Does it still appear to be not uniform on your machine, then?

If it should still does not look uniform, I will withdraw this PR and submit a new one where the Unicode arrows are the fallback solution to the emojis.

Copy link
Owner

@ttytm ttytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the contribution @kevinmatthes!

@ttytm ttytm merged commit 6a87d95 into ttytm:main May 7, 2023
@kevinmatthes kevinmatthes deleted the feature/less-ambigous-wind-direction-arrows branch May 7, 2023 15:04
@ttytm
Copy link
Owner

ttytm commented May 11, 2023

Solved missing arrows on OSX 🎉🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants