Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: mark ConsumerConfig required #1002

Merged
merged 2 commits into from
Feb 22, 2021
Merged

types: mark ConsumerConfig required #1002

merged 2 commits into from
Feb 22, 2021

Conversation

Amorites
Copy link

No description provided.

@Nevon
Copy link
Collaborator

Nevon commented Feb 21, 2021

Thanks for the contribution. I can see how this type was marked as optional since we default to {} in the factory function, but given that we then throw if groupId isn't set, it doesn't make much sense.

@Nevon Nevon merged commit cee4717 into tulios:master Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nevon Nevon Nevon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Amorites @Nevon