Differentiate KafkaMessage type between Record and Message #1401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nevon
force-pushed
the
fix-message-size-type
branch
from
099acbc
to
ebd25c2
Compare
The `size` attribute is only ever present on pre-0.10 `Messages`, and never on the new `Record`. The field was mistakenly defined as being non-optional. Providing a meaningful `size` field for Record is tricky because in RecordBatch all the records are compressed together, rather than individually as is the case with the old Message protocol. Therefore you can only calculate a size for the uncompressed record, which isn't very useful since you most likely care about the size because you want to understand the size over the network.
Nevon
force-pushed
the
fix-message-size-type
branch
from
ebd25c2
to
e1b016e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
sizeattribute is only ever present on pre-0.10Messages, and never on the newRecord. The field was mistakenly defined as being non-optional.