Let consumer crash when no brokers are available #1402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fetch manager rebalancing mechanism caused an infinite loop when there were no brokers available, causing the consumer to never become aware of any connection issues. Fixes #1384
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fetch manager rebalancing mechanism caused an infinite loop when there were no brokers available, causing the consumer to never become aware of any connection issues.
With 2.0.1, if you ran a consumer against a single broker, and then shut that broker down, the consumer would just freeze with no output and use 100% of a CPU core. With this change, the fetcher will try to fetch against one of the now unavailable brokers and have a KafkaJSConnectionError bubble up and eventually crash the consumer, as was the case with <2.0.0.
Fixes #1384