Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ZSTD to codecs and types #157

Merged
merged 2 commits into from
Oct 12, 2018
Merged

Add ZSTD to codecs and types #157

merged 2 commits into from
Oct 12, 2018

Conversation

paambaati
Copy link
Contributor

@tulios
Copy link
Owner

tulios commented Oct 10, 2018

Nice, but looking at your references this will require some more work. I will create a github project with the necessary issues, but just to highlight some things:

New error code

It also introduces a new error code, UNSUPPORTED_COMPRESSION_TYPE (74)

Bump the produce API up to the required version

Zstd will only be allowed for the bumped produce API. That is, for older version clients(=below KAFKA_2_1_IV0), we return UNSUPPORTED_COMPRESSION_TYPE regardless of the message format

Bump the fetch API up to the required version

Zstd will only be allowed for the bumped fetch API. That is, if the requested partition uses zstd and the client version is below KAFKA_2_1_IV0, we return UNSUPPORTED_COMPRESSION_TYPE regardless of the message format. Down-conversion of zstd-compressed records will not be supported.

New experimental flag so we can test until the APIs are stable

@tulios tulios changed the title Add support for ZStandard compression Add ZSTD to codecs and types Oct 10, 2018
@tulios
Copy link
Owner

tulios commented Oct 10, 2018

Here is the project:
https://github.com/tulios/kafkajs/projects/2

@tulios tulios merged commit de2f0d6 into tulios:master Oct 12, 2018
ianwsperber added a commit to ianwsperber/kafkajs that referenced this pull request Oct 12, 2018
@paambaati paambaati deleted the zstandard-compression branch October 15, 2018 09:54
@tulios
Copy link
Owner

tulios commented Sep 16, 2020

@paambaati PR #873 adds the last bit for ZSTD to work, it has been a while, but it's finally here 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants