Add network instrumentation events #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On test mode KafkaJS doesn't wait for the consumers to finish their work before disconnecting which can result in heartbeats after disconnection
|
Tests are failing with Seems like a cool feature set BTW! I'll try to add a review in the next day or so. |
ianwsperber
approved these changes
Dec 20, 2018
Nevon
approved these changes
Dec 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the request timeout configurable, and it introduces network instrumentation events to all clients (producers, consumers and admin). We want to write an easy to use prometheus/statsd/datadog plugin that collects metrics directly from KafkaJS, and we want to use the instrumentation events for that. Issue #175 describes what the official client does but after some research; we concluded that it was too much work and after talking to some people using the java client they mentioned that they don't use the built-in features and have separate integrations with the same providers.
I want to measure the impact of the request queue before defining a default value and making it enabled by default.