Fix uncaught exception on errors.js when 'bugs' field is missing from package.json #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses edge case where if "bugs" field is missing from package.json, error.js has uncaught exception.
EricGeigerQ
changed the title
|
Thanks for the fix! 👍 |
|
This is already available in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #983
Addresses edge case where uncaught exception can occur in errors.js if "bugs" field is missing from package.json.
Tests for 'bugs' field, and if missing, sets issueUrl to null. Side effect is that, if null, the
helpUrlwill not point to new issue path should a KafkaJSInvariantViolation error get thrown.