-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a custom mouse event wrapper around tcell's one #11
Conversation
a00973e
to
f596343
Compare
This wrapper implements the HasMotion() function which value is set by the main application based on the previous mouse event.
f596343
to
562ac8f
Compare
Shouldn't go.mod also be updated to point to gdamore/tcell? |
This can be done afterwards, but I can also add it in this pull request. I already have it ready in n-peugnet@5017f77 (then I am able to build Gomuks with this commit n-peugnet/gomuks@ad0c752). |
@tulir can you please review/merge this? This would be very very useful for maintaining gomuks in Debian |
Now that this PR is merged, can the change to point it to gdamore/tcell go in? |
I just made a new pull request for this: #12 |
I built gomuks with your commits. It does build, however unfortunately, the scrolls do not work properly for me. I try to scroll up/down and nothing happens, or it goes up/down after several attempts. That isn't the case for gomuks built w/o these commits. Asked @alexmyczko to check as well. |
Sorry, you are right, I didn't test this enough. Simply checking that the buttons bitset is the same is not enough. |
Fix scroll regression introduced in #11
This wrapper implements the HasMotion() function which value is set by the main application based on the previous mouse event.
If I understood gdamore/tcell#622 (comment) correctly (emphasis is mine):
With this change, we should be able to use upstream tcell. See #10
I tested this quickly in Gomuks and the selection of text in the message input seemd to behave as expected.