Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Go v1.22 to the CI tests and update staticcheck #462

Merged
merged 2 commits into from
May 13, 2024
Merged

Add Go v1.22 to the CI tests and update staticcheck #462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0247d3
CI: add Go version 1.22 to the matrix of tests
romainbou May 3, 2024
268a6f5
tools: update staticcheck to a version compatible with Go v1.22
romainbou May 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
- name: Setup Go
uses: actions/setup-go@v4
with:
go-version: '1.21.1'
go-version: '1.22.2'

- uses: actions/cache@v3
with:
Expand All @@ -32,7 +32,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
go: ['1.21.1', '1.20.8', '1.19.13', '1.18.10']
go: ['1.22.2', '1.21.9', '1.20.14', '1.19.13', '1.18.10']

steps:
- uses: actions/checkout@v3
Expand Down
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ static_check: check_tools
false;\
fi

@STATICCHECKOUT=$$(staticcheck -go 1.20 -checks all ./...); \
@STATICCHECKOUT=$$(staticcheck -go 1.22 -checks all ./...); \
if [ -z "$$STATICCHECKOUT" ]; then\
echo "staticcheck: OK";\
else \
Expand All @@ -57,7 +57,7 @@ EXECUTABLES = goimports staticcheck
.PHONY: get_tools
get_tools:
go install golang.org/x/tools/cmd/goimports@latest
go install honnef.co/go/tools/cmd/staticcheck@2023.1.5
go install honnef.co/go/tools/cmd/staticcheck@2023.1.7

.PHONY: check_tools
check_tools:
Expand Down
Loading