Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ciphertext packing in bootstrapping #506

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

lehugueni
Copy link
Contributor

@lehugueni lehugueni commented Oct 24, 2024

This PR makes the following changes:

Regarding the last point, the following methods have been made private:

  • pack
  • unpack
  • switchRingDegreeN1ToN2New
  • switchRingDegreeN2ToN1New

The idea is that users could want to pack and unpack themselves (using PackAndSwitchN1ToN2 and UnpackAndSwitchN2toN1) to take advantage of the packing, but the lower level functions are not meant to be used outside of this context. Any feedback on that is much appreciated.

@lehugueni lehugueni self-assigned this Oct 24, 2024
@lehugueni lehugueni added bug Something isn't working enhancement New feature or request labels Oct 24, 2024
@lehugueni lehugueni requested a review from MGeorgie October 25, 2024 12:00
@lehugueni lehugueni marked this pull request as ready for review October 25, 2024 12:00
Copy link
Collaborator

@Pro7ech Pro7ech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The solution works, but I think something could be better could be done. My intuition is that the ring packing package could be used to simplify the code and avoid code duplication. I'm not convinced that a packed ciphertext struct is needed, nor do I think it should be public. If it is chosen to be kept and be public, then it should be a ciphertext of the ring packing package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
3 participants