Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NuGetPackageRoot doesn't always have a trailing slash #33

Merged
merged 1 commit into from
Oct 1, 2019
Merged

NuGetPackageRoot doesn't always have a trailing slash #33

merged 1 commit into from
Oct 1, 2019

Conversation

jnm2
Copy link
Contributor

@jnm2 jnm2 commented Sep 30, 2019 •
edited
Loading

As evidenced by:

<?xml version="1.0" encoding="utf-8"?>
<configuration>
  <config>
    <add key="globalPackagesFolder" value="packages" />
  </config>
</configuration>

MSBuild Structured Log Viewer:

image

image

The result is that all reference assemblies go silently unannotated:

AnnotateReferenceAssemblies:
Skipping target "AnnotateReferenceAssemblies" because it has no inputs.

jnm2
jnm2 commented Sep 30, 2019
View reviewed changes
TunnelVisionLabs.ReferenceAssemblyAnnotator/TunnelVisionLabs.ReferenceAssemblyAnnotator.targets
@@ -24,7 +24,7 @@
</PropertyGroup>

<PropertyGroup>
<AnnotatedReferenceAssemblyDirectory Condition="'$(AnnotatedReferenceAssemblyDirectory)' == ''">$(NuGetPackageRoot)microsoft.netcore.app.ref\$(AnnotatedReferenceAssemblyVersion)\ref\netcoreapp3.0\</AnnotatedReferenceAssemblyDirectory>
<AnnotatedReferenceAssemblyDirectory Condition="'$(AnnotatedReferenceAssemblyDirectory)' == ''">$(NuGetPackageRoot)\microsoft.netcore.app.ref\$(AnnotatedReferenceAssemblyVersion)\ref\netcoreapp3.0\</AnnotatedReferenceAssemblyDirectory>
Copy link
Contributor Author

@jnm2 jnm2 Sep 30, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everywhere else $(NuGetPackageRoot) appeared in the preprocessed project, it was followed with a trailing slash.

@sharwell sharwell merged commit 681877d into tunnelvisionlabs:master Oct 1, 2019
@jnm2 jnm2 deleted the nuget_root_can_be_without_trailing_slash branch October 1, 2019 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jnm2 @sharwell