Add ability to re-run scripts on back/forward navigation

[Thibaut]

… by specifying data-turbolinks-eval=true on the <script> tag.

Fix #507.

cc @reed @kevinhughes27

[kevinhughes27]

👍

[reed]

I'm on board with the functionality, but I'm not sure about the name of the attribute. Seems strange that data-turbolinks-eval=true and data-turbolinks-eval=false don't mean opposite things. Plus, I think it's always been implied that any script tag without a data-turbolinks-eval=false attribute meant that data-turbolinks-eval=true.

Off the top of my head, some alternative names could be data-turbolinks-cache-eval, data-turbolinks-history-eval, data-turbolinks-re-eval, or data-turbolinks-always-eval. Or any other name you think might be better.

[Thibaut]

How about data-turbolinks-eval=always?

[reed]

That would work.

[Thibaut]

Updated 👍

[reed]

Thanks

[Thibaut]

@reed good catch on the name. data-turbolinks-eval=false was confusing.

On Apr 18, 2015, at 12:58, Nick Reed notifications@github.com wrote:

Thanks

—
Reply to this email directly or view it on GitHub.

[kevinhughes27]

I like it! thanks guys!

[gregblass]

Any idea how I could add this to code in application.js where there is no script tag? And any advice on how I'd go about using this with all the baked in bootstrap stuff that I'm using? (popovers, tooltips, modals, etc)

Edit: Stupid question. Just put your code in a script tag with data-turbolinks-eval=always on the bottom of your application.html.erb. It probably should be in application.js anyway. And take it out of a document onready. Then it will fire every time, even with back and forward.

[Thibaut]

@gregblass bind a function to the page:load event. It'll get called every time the page changes (including on back/forward navigation).