Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add table azure_tenant closes #140 #142

Merged
merged 3 commits into from
Jun 2, 2021
Merged

Add table azure_tenant closes #140 #142

merged 3 commits into from
Jun 2, 2021

Conversation

ParthaI
Copy link
Contributor

@ParthaI ParthaI commented May 27, 2021

Integration test logs

Logs
SETUP: tests/azure_tenant []
PRETEST: tests/azure_tenant
TEST: tests/azure_tenant
Running terraform
data.azurerm_client_config.current: Refreshing state...
Apply complete! Resources: 0 added, 0 changed, 0 destroyed.
Outputs:
current_tenant_display_name = cdffd708-7da0-4cea-abeb-0a4c334d7f64
tenant_id = cdffd708-7da0-4cea-abeb-0a4c334d7f64
Running SQL query: test-list-query.sql
[
  {
    "display_name": null,
    "name": "cdffd708-7da0-4cea-abeb-0a4c334d7f64",
    "tenant_id": "cdffd708-7da0-4cea-abeb-0a4c334d7f64"
  }
]
✔ PASSED
Running SQL query: test-notfound-query.sql
null
✔ PASSED
Running SQL query: test-turbot-query.sql
[
  {
    "name": "cdffd708-7da0-4cea-abeb-0a4c334d7f64",
    "title": "cdffd708-7da0-4cea-abeb-0a4c334d7f64"
  }
]
✔ PASSED
POSTTEST: tests/azure_tenant
TEARDOWN: tests/azure_tenant
SUMMARY:
1/1 passed.

Example query results

Results
select
  name,
  id,
  tenant_id,
  tenant_category,
  country,
  country_code,
  display_name,
  domains
from
  azure_tenant;
+--------------------------------------+-----------------------------------------------+--------------------------------------+-----------------+---------+--------------+--------------+---------+
| name                                 | id                                            | tenant_id                            | tenant_category | country | country_code | display_name | domains |
+--------------------------------------+-----------------------------------------------+--------------------------------------+-----------------+---------+--------------+--------------+---------+
| cdffd708-7da0-4cea-abeb-0a4c334d7f64 | /tenants/cdffd708-7da0-4cea-abeb-0a4c334d7f64 | cdffd708-7da0-4cea-abeb-0a4c334d7f64 | Home            | <null>  | <null>       | <null>       | <null>  |
+--------------------------------------+-----------------------------------------------+--------------------------------------+-----------------+---------+--------------+--------------+---------+

@ParthaI ParthaI requested a review from khushboo9024 May 27, 2021 04:28
@ParthaI ParthaI self-assigned this May 27, 2021
@ParthaI ParthaI linked an issue May 27, 2021 that may be closed by this pull request
@LalitLab LalitLab requested review from LalitLab and removed request for khushboo9024 May 27, 2021 11:52
Name: "akas",
Description: ColumnDescriptionAkas,
Type: proto.ColumnType_JSON,
Transform: transform.FromField("ID").Transform(idToAkas),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

 ["azure:///tenants/cdffd708-7da0-4cea-abeb-0a4c334d7f64","azure:///tenants/cdffd708-7da0-4cea-abeb-0a4c334d7f64"]

both values are same - can we keep only one of it for this table

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@LalitLab LalitLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ParthaI left few comments

Copy link
Contributor

@LalitLab LalitLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@rajlearner17 rajlearner17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LalitLab LalitLab requested a review from cbruno10 June 2, 2021 06:01
@cbruno10 cbruno10 merged commit 98ff506 into main Jun 2, 2021
@cbruno10 cbruno10 deleted the issue-140 branch June 2, 2021 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add table azure_tenant
4 participants