-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add table azure_compute_virtual_machine_scale_set closes #190 #249
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add extensions details for VM scale set.
https://docs.microsoft.com/en-us/rest/api/compute/virtual-machine-scale-set-vm-extensions/list
|
||
name := d.KeyColumnQuals["name"].GetStringValue() | ||
resourceGroup := d.KeyColumnQuals["resource_group"].GetStringValue() | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add empty check for name
and resource_group
.
@@ -0,0 +1,32 @@ | |||
# Table: azure_virtual_machine_scale_set | |||
|
|||
A virtual network gateway is used to establish secure, cross-premises connectivity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description is not proper, please change.
|
||
func tableAzureVirtualMachineScaleSet(_ context.Context) *plugin.Table { | ||
return &plugin.Table{ | ||
Name: "azure_virtual_machine_scale_set", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Table name should be azure_compute_virtual_machine_scale_set
…compute_virtual_machine_scale_set
added description for column
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Integration test logs
Logs
Example query results
Results
Basic Info
List Standard tier virtual machine scale set
List extensions for VM Scale set