Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Private Endpoint Connection details in table azure_data_factory closes #285 #298

Merged
merged 7 commits into from
Sep 16, 2021
Merged

Add Private Endpoint Connection details in table azure_data_factory closes #285 #298

merged 7 commits into from
Sep 16, 2021

Conversation

ParthaI
Copy link
Contributor

@ParthaI ParthaI commented Sep 7, 2021 •
edited by bigdatasourav
Loading

Integration test logs

Logs 
No env file present for the current environment:  staging 
 Falling back to .env config
No env file present for the current environment:  staging
customEnv TURBOT_TEST_EXPECTED_TIMEOUT undefined

SETUP: tests/azure_data_factory []

PRETEST: tests/azure_data_factory

TEST: tests/azure_data_factory
Running terraform
data.azurerm_client_config.current: Refreshing state...
data.null_data_source.resource: Refreshing state...
azurerm_resource_group.named_test_resource: Creating...
azurerm_resource_group.named_test_resource: Creation complete after 2s [id=/subscriptions/d46d7416-f95f-4771-bbb5-529d4c76659c/resourceGroups/turbottest45505]
azurerm_data_factory.named_test_resource: Creating...
azurerm_data_factory.named_test_resource: Still creating... [10s elapsed]
azurerm_data_factory.named_test_resource: Creation complete after 12s [id=/subscriptions/d46d7416-f95f-4771-bbb5-529d4c76659c/resourceGroups/turbottest45505/providers/Microsoft.DataFactory/factories/turbottest45505]

Warning: Deprecated Resource

The null_data_source was historically used to construct intermediate values to
re-use elsewhere in configuration, the same can now be achieved using locals


Apply complete! Resources: 2 added, 0 changed, 0 destroyed.

Outputs:

location = eastus
resource_aka = azure:///subscriptions/d46d7416-f95f-4771-bbb5-529d4c76659c/resourceGroups/turbottest45505/providers/Microsoft.DataFactory/factories/turbottest45505
resource_aka_lower = azure:///subscriptions/d46d7416-f95f-4771-bbb5-529d4c76659c/resourcegroups/turbottest45505/providers/microsoft.datafactory/factories/turbottest45505
resource_id = /subscriptions/d46d7416-f95f-4771-bbb5-529d4c76659c/resourceGroups/turbottest45505/providers/Microsoft.DataFactory/factories/turbottest45505
resource_name = turbottest45505
subscription_id = d46d7416-f95f-4771-bbb5-529d4c76659c

Running SQL query: test-get-query.sql
2021-09-07T13:03:27.001+0530 [TRACE] steampipe: db.EnsureDbAndStartService start
2021-09-07T13:03:27.001+0530 [TRACE] steampipe: ensure installed
2021-09-07T13:03:27.003+0530 [TRACE] steampipe: ensured installed
2021-09-07T13:03:27.026+0530 [TRACE] steampipe: GetRunStatus - pid 10614 does not exist
2021-09-07T13:03:27.027+0530 [TRACE] steampipe: start implicit service
2021-09-07T13:03:27.027+0530 [TRACE] steampipe: GetRunStatus - loadRunningInstanceInfo returned nil
2021-09-07T13:03:27.032+0530 [TRACE] steampipe: createDbClient
2021-09-07T13:03:27.057+0530 [TRACE] steampipe: status:  &{12893 9193 [localhost 127.0.0.1] local query 0b16-4900-92e3 steampipe steampipe}
2021-09-07T13:03:27.057+0530 [TRACE] steampipe: Connection string:  host=localhost port=9193 user=root dbname=postgres sslmode=require
2021-09-07T13:03:27.144+0530 [TRACE] steampipe: createDbClient
2021-09-07T13:03:27.170+0530 [TRACE] steampipe: status:  &{12893 9193 [localhost 127.0.0.1] local query 0b16-4900-92e3 steampipe steampipe}
2021-09-07T13:03:27.170+0530 [TRACE] steampipe: Connection string:  host=localhost port=9193 user=root dbname=steampipe sslmode=require
2021-09-07T13:03:27.231+0530 [TRACE] steampipe: createDbClient
2021-09-07T13:03:27.258+0530 [TRACE] steampipe: status:  &{12893 9193 [localhost 127.0.0.1] local query 0b16-4900-92e3 steampipe steampipe}
2021-09-07T13:03:27.258+0530 [TRACE] steampipe: Connection string:  host=localhost port=9193 user=root dbname=steampipe sslmode=require
2021-09-07T13:03:27.281+0530 [TRACE] steampipe: getQueryInitDataAsync
2021-09-07T13:03:27.296+0530 [TRACE] steampipe: createDbClient
2021-09-07T13:03:27.322+0530 [TRACE] steampipe: status:  &{12893 9193 [localhost 127.0.0.1] local query 0b16-4900-92e3 steampipe steampipe}
2021-09-07T13:03:27.322+0530 [TRACE] steampipe: Connection string:  host=localhost port=9193 user=steampipe dbname=steampipe sslmode=require
2021-09-07T13:03:29.487+0530 [TRACE] steampipe: RefreshConnections, updates: &{Update:map[] Delete:map[] MissingPlugins:[] RequiredConnections:map[alicloud:0xc000031270 aws:0xc000031310 azure:0xc000031360 gcp:0xc0000313b0 oci:0xc000031540 okta:0xc0000315e0 zendesk:0xc000031220]}
2021-09-07T13:03:29.487+0530 [TRACE] steampipe: no connections to update
2021-09-07T13:03:29.487+0530 [TRACE] steampipe: createDbClient
2021-09-07T13:03:29.512+0530 [TRACE] steampipe: status:  &{12893 9193 [localhost 127.0.0.1] local query 0b16-4900-92e3 steampipe steampipe}
2021-09-07T13:03:29.512+0530 [TRACE] steampipe: Connection string:  host=localhost port=9193 user=root dbname=steampipe sslmode=require
2021-09-07T13:03:29.550+0530 [TRACE] steampipe: setting service search path to ["public" "alicloud" "aws" "azure" "gcp" "oci" "okta" "zendesk" "internal"]
2021-09-07T13:03:29.551+0530 [TRACE] steampipe: createDbClient
2021-09-07T13:03:29.581+0530 [TRACE] steampipe: status:  &{12893 9193 [localhost 127.0.0.1] local query 0b16-4900-92e3 steampipe steampipe}
2021-09-07T13:03:29.581+0530 [TRACE] steampipe: Connection string:  host=localhost port=9193 user=steampipe dbname=steampipe sslmode=require
2021-09-07T13:03:30.646+0530 [TRACE] steampipe: getQueryInitDataAsync complete
2021-09-07T13:03:33.788+0530 [TRACE] steampipe: createDbClient
2021-09-07T13:03:33.814+0530 [TRACE] steampipe: status:  &{12893 9193 [localhost 127.0.0.1] local query 0b16-4900-92e3 steampipe steampipe}
2021-09-07T13:03:33.814+0530 [TRACE] steampipe: Connection string:  host=localhost port=9193 user=root dbname=steampipe sslmode=require
2021-09-07T13:03:33.847+0530 [TRACE] steampipe: StopDB false
[
  {
    "id": "/subscriptions/d46d7416-f95f-4771-bbb5-529d4c76659c/resourceGroups/turbottest45505/providers/Microsoft.DataFactory/factories/turbottest45505",
    "name": "turbottest45505",
    "region": "eastus",
    "resource_group": "turbottest45505",
    "subscription_id": "d46d7416-f95f-4771-bbb5-529d4c76659c",
    "tags": {
      "name": "turbottest45505"
    },
    "type": "Microsoft.DataFactory/factories"
  }
]
✔ PASSED

Running SQL query: test-list-query.sql
2021-09-07T13:03:34.009+0530 [TRACE] steampipe: db.EnsureDbAndStartService start
2021-09-07T13:03:34.009+0530 [TRACE] steampipe: ensure installed
2021-09-07T13:03:34.009+0530 [TRACE] steampipe: ensured installed
2021-09-07T13:03:34.030+0530 [TRACE] steampipe: GetRunStatus - pid 12893 does not exist
2021-09-07T13:03:34.030+0530 [TRACE] steampipe: start implicit service
2021-09-07T13:03:34.030+0530 [TRACE] steampipe: GetRunStatus - loadRunningInstanceInfo returned nil
2021-09-07T13:03:34.034+0530 [TRACE] steampipe: createDbClient
2021-09-07T13:03:34.064+0530 [TRACE] steampipe: status:  &{12954 9193 [localhost 127.0.0.1] local query 0b16-4900-92e3 steampipe steampipe}
2021-09-07T13:03:34.064+0530 [TRACE] steampipe: Connection string:  host=localhost port=9193 user=root dbname=postgres sslmode=require
2021-09-07T13:03:34.094+0530 [TRACE] steampipe: createDbClient
2021-09-07T13:03:34.119+0530 [TRACE] steampipe: status:  &{12954 9193 [localhost 127.0.0.1] local query 0b16-4900-92e3 steampipe steampipe}
2021-09-07T13:03:34.119+0530 [TRACE] steampipe: Connection string:  host=localhost port=9193 user=root dbname=steampipe sslmode=require
2021-09-07T13:03:34.142+0530 [TRACE] steampipe: createDbClient
2021-09-07T13:03:34.167+0530 [TRACE] steampipe: status:  &{12954 9193 [localhost 127.0.0.1] local query 0b16-4900-92e3 steampipe steampipe}
2021-09-07T13:03:34.167+0530 [TRACE] steampipe: Connection string:  host=localhost port=9193 user=root dbname=steampipe sslmode=require
2021-09-07T13:03:34.188+0530 [TRACE] steampipe: getQueryInitDataAsync
2021-09-07T13:03:34.196+0530 [TRACE] steampipe: createDbClient
2021-09-07T13:03:34.222+0530 [TRACE] steampipe: status:  &{12954 9193 [localhost 127.0.0.1] local query 0b16-4900-92e3 steampipe steampipe}
2021-09-07T13:03:34.222+0530 [TRACE] steampipe: Connection string:  host=localhost port=9193 user=steampipe dbname=steampipe sslmode=require
2021-09-07T13:03:35.813+0530 [TRACE] steampipe: RefreshConnections, updates: &{Update:map[] Delete:map[] MissingPlugins:[] RequiredConnections:map[alicloud:0xc0000303c0 aws:0xc000030460 azure:0xc0000304b0 gcp:0xc000030500 oci:0xc0000302d0 okta:0xc000030320 zendesk:0xc000030370]}
2021-09-07T13:03:35.813+0530 [TRACE] steampipe: no connections to update
2021-09-07T13:03:35.813+0530 [TRACE] steampipe: createDbClient
2021-09-07T13:03:35.839+0530 [TRACE] steampipe: status:  &{12954 9193 [localhost 127.0.0.1] local query 0b16-4900-92e3 steampipe steampipe}
2021-09-07T13:03:35.839+0530 [TRACE] steampipe: Connection string:  host=localhost port=9193 user=root dbname=steampipe sslmode=require
2021-09-07T13:03:35.866+0530 [TRACE] steampipe: setting service search path to ["public" "alicloud" "aws" "azure" "gcp" "oci" "okta" "zendesk" "internal"]
2021-09-07T13:03:35.867+0530 [TRACE] steampipe: createDbClient
2021-09-07T13:03:35.895+0530 [TRACE] steampipe: status:  &{12954 9193 [localhost 127.0.0.1] local query 0b16-4900-92e3 steampipe steampipe}
2021-09-07T13:03:35.895+0530 [TRACE] steampipe: Connection string:  host=localhost port=9193 user=steampipe dbname=steampipe sslmode=require
2021-09-07T13:03:36.815+0530 [TRACE] steampipe: getQueryInitDataAsync complete
2021-09-07T13:03:39.422+0530 [TRACE] steampipe: createDbClient
2021-09-07T13:03:39.449+0530 [TRACE] steampipe: status:  &{12954 9193 [localhost 127.0.0.1] local query 0b16-4900-92e3 steampipe steampipe}
2021-09-07T13:03:39.449+0530 [TRACE] steampipe: Connection string:  host=localhost port=9193 user=root dbname=steampipe sslmode=require
2021-09-07T13:03:39.476+0530 [TRACE] steampipe: StopDB false
[
  {
    "id": "/subscriptions/d46d7416-f95f-4771-bbb5-529d4c76659c/resourceGroups/turbottest45505/providers/Microsoft.DataFactory/factories/turbottest45505",
    "name": "turbottest45505",
    "type": "Microsoft.DataFactory/factories"
  }
]
✔ PASSED

Running SQL query: test-not-found-query.sql
2021-09-07T13:03:39.641+0530 [TRACE] steampipe: db.EnsureDbAndStartService start
2021-09-07T13:03:39.641+0530 [TRACE] steampipe: ensure installed
2021-09-07T13:03:39.641+0530 [TRACE] steampipe: ensured installed
2021-09-07T13:03:39.674+0530 [TRACE] steampipe: GetRunStatus - pid 12954 does not exist
2021-09-07T13:03:39.675+0530 [TRACE] steampipe: start implicit service
2021-09-07T13:03:39.675+0530 [TRACE] steampipe: GetRunStatus - loadRunningInstanceInfo returned nil
2021-09-07T13:03:39.678+0530 [TRACE] steampipe: createDbClient
2021-09-07T13:03:39.706+0530 [TRACE] steampipe: status:  &{13014 9193 [localhost 127.0.0.1] local query 0b16-4900-92e3 steampipe steampipe}
2021-09-07T13:03:39.706+0530 [TRACE] steampipe: Connection string:  host=localhost port=9193 user=root dbname=postgres sslmode=require
2021-09-07T13:03:39.742+0530 [TRACE] steampipe: createDbClient
2021-09-07T13:03:39.766+0530 [TRACE] steampipe: status:  &{13014 9193 [localhost 127.0.0.1] local query 0b16-4900-92e3 steampipe steampipe}
2021-09-07T13:03:39.766+0530 [TRACE] steampipe: Connection string:  host=localhost port=9193 user=root dbname=steampipe sslmode=require
2021-09-07T13:03:39.793+0530 [TRACE] steampipe: createDbClient
2021-09-07T13:03:39.819+0530 [TRACE] steampipe: status:  &{13014 9193 [localhost 127.0.0.1] local query 0b16-4900-92e3 steampipe steampipe}
2021-09-07T13:03:39.819+0530 [TRACE] steampipe: Connection string:  host=localhost port=9193 user=root dbname=steampipe sslmode=require
2021-09-07T13:03:39.838+0530 [TRACE] steampipe: getQueryInitDataAsync
2021-09-07T13:03:39.843+0530 [TRACE] steampipe: createDbClient
2021-09-07T13:03:39.870+0530 [TRACE] steampipe: status:  &{13014 9193 [localhost 127.0.0.1] local query 0b16-4900-92e3 steampipe steampipe}
2021-09-07T13:03:39.870+0530 [TRACE] steampipe: Connection string:  host=localhost port=9193 user=steampipe dbname=steampipe sslmode=require
2021-09-07T13:03:41.415+0530 [TRACE] steampipe: RefreshConnections, updates: &{Update:map[] Delete:map[] MissingPlugins:[] RequiredConnections:map[alicloud:0xc00058a3c0 aws:0xc00058a410 azure:0xc00058a460 gcp:0xc00058a4b0 oci:0xc00058a2d0 okta:0xc00058a320 zendesk:0xc00058a370]}
2021-09-07T13:03:41.415+0530 [TRACE] steampipe: no connections to update
2021-09-07T13:03:41.415+0530 [TRACE] steampipe: createDbClient
2021-09-07T13:03:41.444+0530 [TRACE] steampipe: status:  &{13014 9193 [localhost 127.0.0.1] local query 0b16-4900-92e3 steampipe steampipe}
2021-09-07T13:03:41.444+0530 [TRACE] steampipe: Connection string:  host=localhost port=9193 user=root dbname=steampipe sslmode=require
2021-09-07T13:03:41.471+0530 [TRACE] steampipe: setting service search path to ["public" "alicloud" "aws" "azure" "gcp" "oci" "okta" "zendesk" "internal"]
2021-09-07T13:03:41.472+0530 [TRACE] steampipe: createDbClient
2021-09-07T13:03:41.499+0530 [TRACE] steampipe: status:  &{13014 9193 [localhost 127.0.0.1] local query 0b16-4900-92e3 steampipe steampipe}
2021-09-07T13:03:41.499+0530 [TRACE] steampipe: Connection string:  host=localhost port=9193 user=steampipe dbname=steampipe sslmode=require
2021-09-07T13:03:42.411+0530 [TRACE] steampipe: getQueryInitDataAsync complete
2021-09-07T13:03:44.310+0530 [TRACE] steampipe: createDbClient
2021-09-07T13:03:44.344+0530 [TRACE] steampipe: status:  &{13014 9193 [localhost 127.0.0.1] local query 0b16-4900-92e3 steampipe steampipe}
2021-09-07T13:03:44.344+0530 [TRACE] steampipe: Connection string:  host=localhost port=9193 user=root dbname=steampipe sslmode=require
2021-09-07T13:03:44.372+0530 [TRACE] steampipe: StopDB false
null
✔ PASSED

Running SQL query: test-turbot-query.sql
2021-09-07T13:03:44.535+0530 [TRACE] steampipe: db.EnsureDbAndStartService start
2021-09-07T13:03:44.535+0530 [TRACE] steampipe: ensure installed
2021-09-07T13:03:44.536+0530 [TRACE] steampipe: ensured installed
2021-09-07T13:03:44.557+0530 [TRACE] steampipe: GetRunStatus - pid 13014 does not exist
2021-09-07T13:03:44.558+0530 [TRACE] steampipe: start implicit service
2021-09-07T13:03:44.558+0530 [TRACE] steampipe: GetRunStatus - loadRunningInstanceInfo returned nil
2021-09-07T13:03:44.561+0530 [TRACE] steampipe: createDbClient
2021-09-07T13:03:44.588+0530 [TRACE] steampipe: status:  &{13075 9193 [localhost 127.0.0.1] local query 0b16-4900-92e3 steampipe steampipe}
2021-09-07T13:03:44.588+0530 [TRACE] steampipe: Connection string:  host=localhost port=9193 user=root dbname=postgres sslmode=require
2021-09-07T13:03:44.618+0530 [TRACE] steampipe: createDbClient
2021-09-07T13:03:44.645+0530 [TRACE] steampipe: status:  &{13075 9193 [localhost 127.0.0.1] local query 0b16-4900-92e3 steampipe steampipe}
2021-09-07T13:03:44.645+0530 [TRACE] steampipe: Connection string:  host=localhost port=9193 user=root dbname=steampipe sslmode=require
2021-09-07T13:03:44.672+0530 [TRACE] steampipe: createDbClient
2021-09-07T13:03:44.698+0530 [TRACE] steampipe: status:  &{13075 9193 [localhost 127.0.0.1] local query 0b16-4900-92e3 steampipe steampipe}
2021-09-07T13:03:44.698+0530 [TRACE] steampipe: Connection string:  host=localhost port=9193 user=root dbname=steampipe sslmode=require
2021-09-07T13:03:44.721+0530 [TRACE] steampipe: getQueryInitDataAsync
2021-09-07T13:03:44.729+0530 [TRACE] steampipe: createDbClient
2021-09-07T13:03:44.754+0530 [TRACE] steampipe: status:  &{13075 9193 [localhost 127.0.0.1] local query 0b16-4900-92e3 steampipe steampipe}
2021-09-07T13:03:44.754+0530 [TRACE] steampipe: Connection string:  host=localhost port=9193 user=steampipe dbname=steampipe sslmode=require
2021-09-07T13:03:46.305+0530 [TRACE] steampipe: RefreshConnections, updates: &{Update:map[] Delete:map[] MissingPlugins:[] RequiredConnections:map[alicloud:0xc0000a9310 aws:0xc0000a9360 azure:0xc0000a8d70 gcp:0xc0000a8dc0 oci:0xc0000a91d0 okta:0xc0000a9270 zendesk:0xc0000a92c0]}
2021-09-07T13:03:46.305+0530 [TRACE] steampipe: no connections to update
2021-09-07T13:03:46.305+0530 [TRACE] steampipe: createDbClient
2021-09-07T13:03:46.331+0530 [TRACE] steampipe: status:  &{13075 9193 [localhost 127.0.0.1] local query 0b16-4900-92e3 steampipe steampipe}
2021-09-07T13:03:46.331+0530 [TRACE] steampipe: Connection string:  host=localhost port=9193 user=root dbname=steampipe sslmode=require
2021-09-07T13:03:46.356+0530 [TRACE] steampipe: setting service search path to ["public" "alicloud" "aws" "azure" "gcp" "oci" "okta" "zendesk" "internal"]
2021-09-07T13:03:46.357+0530 [TRACE] steampipe: createDbClient
2021-09-07T13:03:46.384+0530 [TRACE] steampipe: status:  &{13075 9193 [localhost 127.0.0.1] local query 0b16-4900-92e3 steampipe steampipe}
2021-09-07T13:03:46.384+0530 [TRACE] steampipe: Connection string:  host=localhost port=9193 user=steampipe dbname=steampipe sslmode=require
2021-09-07T13:03:47.297+0530 [TRACE] steampipe: getQueryInitDataAsync complete
2021-09-07T13:03:50.050+0530 [TRACE] steampipe: createDbClient
2021-09-07T13:03:50.077+0530 [TRACE] steampipe: status:  &{13075 9193 [localhost 127.0.0.1] local query 0b16-4900-92e3 steampipe steampipe}
2021-09-07T13:03:50.077+0530 [TRACE] steampipe: Connection string:  host=localhost port=9193 user=root dbname=steampipe sslmode=require
2021-09-07T13:03:50.106+0530 [TRACE] steampipe: StopDB false
[
  {
    "akas": [
      "azure:///subscriptions/d46d7416-f95f-4771-bbb5-529d4c76659c/resourceGroups/turbottest45505/providers/Microsoft.DataFactory/factories/turbottest45505",
      "azure:///subscriptions/d46d7416-f95f-4771-bbb5-529d4c76659c/resourcegroups/turbottest45505/providers/microsoft.datafactory/factories/turbottest45505"
    ],
    "name": "turbottest45505",
    "tags": {
      "name": "turbottest45505"
    },
    "title": "turbottest45505"
  }
]
✔ PASSED

POSTTEST: tests/azure_data_factory

TEARDOWN: tests/azure_data_factory

SUMMARY:

1/1 passed.

Example query results

Results 
select jsonb_pretty(private_endpoint_connections) as private_endpoint_connections from azure_data_factory
+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
| private_endpoint_connections                                                                                                                                                                              
+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
| [                                                                                                                                                                                                         
|     {                                                                                                                                                                                                     
|         "Etag": "24006308-0000-0100-0000-614332e70000",                                                                                                                                                   
|         "PrivateEndpointId": "/subscriptions/d46d7416-f95f-4771-bbb5-529d4c76659c/resourceGroups/turbot_rg/providers/Microsoft.Network/privateEndpoints/test-pvc",                                        
|         "ProvisioningState": "Succeeded",                                                                                                                                                                 
|         "PrivateEndpointConnectionId": "/subscriptions/d46d7416-f95f-4771-bbb5-529d4c76659c/resourceGroups/turbot_rg/providers/Microsoft.DataFactory/factories/test-datafactory54/privateendpointconnectio
|         "PrivateEndpointConnectionName": "test-datafactory54.77bc046b-1c02-472d-aa0a-234c6c3092ef",                                                                                                       
|         "PrivateEndpointConnectionType": "Microsoft.DataFactory/factories/privateendpointconnections",                                                                                                    
|         "PrivateLinkServiceConnectionStateStatus": "Approved",                                                                                                                                            
|         "PrivateLinkServiceConnectionStateDescription": "Auto-Approved",                                                                                                                                  
|         "PrivateLinkServiceConnectionStateActionsRequired": "None"                                                                                                                                        
|     }                                                                                                                                                                                                     
| ]                                                                                                                                                                                                         
+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

@ParthaI ParthaI self-assigned this Sep 7, 2021
@ParthaI ParthaI changed the title Add Private Endpoint Connection details in table azure_data_factory c… Add Private Endpoint Connection details in table azure_data_factory closes #285 Sep 7, 2021
@ParthaI ParthaI linked an issue Sep 7, 2021 that may be closed by this pull request
Add Private Endpoint Connection details in table azure_data_factory #285
Closed
bigdatasourav
bigdatasourav approved these changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@bigdatasourav bigdatasourav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bigdatasourav bigdatasourav merged commit 0f43a0c into main Sep 16, 2021
@bigdatasourav bigdatasourav deleted the issue-285 branch September 16, 2021 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigdatasourav bigdatasourav bigdatasourav approved these changes

@khushboo9024 khushboo9024 Awaiting requested review from khushboo9024

Assignees

@ParthaI ParthaI

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Private Endpoint Connection details in table azure_data_factory
2 participants
@ParthaI @bigdatasourav