Add table azure_eventgrid_domain closes #293 #314

ParthaI · 2021-09-09T10:43:06Z

Integration test logs

Logs

No env file present for the current environment:  staging 
 Falling back to .env config
No env file present for the current environment:  staging
customEnv TURBOT_TEST_EXPECTED_TIMEOUT undefined

SETUP: tests/azure_eventgrid_domain []

PRETEST: tests/azure_eventgrid_domain

TEST: tests/azure_eventgrid_domain
Running terraform
data.azurerm_client_config.current: Refreshing state...
data.null_data_source.resource: Refreshing state...
azurerm_resource_group.named_test_resource: Creating...
azurerm_resource_group.named_test_resource: Creation complete after 5s [id=/subscriptions/d46d7416-f95f-4771-bbb5-529d4c76659c/resourceGroups/turbottest52980]
azurerm_eventgrid_domain.named_test_resource: Creating...
azurerm_eventgrid_domain.named_test_resource: Still creating... [10s elapsed]
azurerm_eventgrid_domain.named_test_resource: Still creating... [20s elapsed]
azurerm_eventgrid_domain.named_test_resource: Creation complete after 27s [id=/subscriptions/d46d7416-f95f-4771-bbb5-529d4c76659c/resourceGroups/turbottest52980/providers/Microsoft.EventGrid/domains/turbottest52980]

Warning: Deprecated Resource

The null_data_source was historically used to construct intermediate values to
re-use elsewhere in configuration, the same can now be achieved using locals


Apply complete! Resources: 2 added, 0 changed, 0 destroyed.

Outputs:

resource_aka = azure:///subscriptions/d46d7416-f95f-4771-bbb5-529d4c76659c/resourceGroups/turbottest52980/providers/Microsoft.EventGrid/domains/turbottest52980
resource_aka_lower = azure:///subscriptions/d46d7416-f95f-4771-bbb5-529d4c76659c/resourcegroups/turbottest52980/providers/microsoft.eventgrid/domains/turbottest52980
resource_id = /subscriptions/d46d7416-f95f-4771-bbb5-529d4c76659c/resourceGroups/turbottest52980/providers/Microsoft.EventGrid/domains/turbottest52980
resource_name = turbottest52980
subscription_id = d46d7416-f95f-4771-bbb5-529d4c76659c

Running SQL query: test-get-query.sql
[
  {
    "id": "/subscriptions/d46d7416-f95f-4771-bbb5-529d4c76659c/resourceGroups/turbottest52980/providers/Microsoft.EventGrid/domains/turbottest52980",
    "name": "turbottest52980",
    "type": "Microsoft.EventGrid/domains"
  }
]
✔ PASSED

Running SQL query: test-hydrate-query.sql
[
  {
    "akas": [
      "azure:///subscriptions/d46d7416-f95f-4771-bbb5-529d4c76659c/resourceGroups/turbottest52980/providers/Microsoft.EventGrid/domains/turbottest52980",
      "azure:///subscriptions/d46d7416-f95f-4771-bbb5-529d4c76659c/resourcegroups/turbottest52980/providers/microsoft.eventgrid/domains/turbottest52980"
    ],
    "name": "turbottest52980",
    "title": "turbottest52980"
  }
]
✔ PASSED

Running SQL query: test-list-query.sql
[
  {
    "id": "/subscriptions/d46d7416-f95f-4771-bbb5-529d4c76659c/resourceGroups/turbottest52980/providers/Microsoft.EventGrid/domains/turbottest52980",
    "name": "turbottest52980"
  }
]
✔ PASSED

Running SQL query: test-not-found-query.sql
null
✔ PASSED

Running SQL query: test-turbot-query.sql
[
  {
    "akas": [
      "azure:///subscriptions/d46d7416-f95f-4771-bbb5-529d4c76659c/resourceGroups/turbottest52980/providers/Microsoft.EventGrid/domains/turbottest52980",
      "azure:///subscriptions/d46d7416-f95f-4771-bbb5-529d4c76659c/resourcegroups/turbottest52980/providers/microsoft.eventgrid/domains/turbottest52980"
    ],
    "name": "turbottest52980",
    "title": "turbottest52980"
  }
]
✔ PASSED

POSTTEST: tests/azure_eventgrid_domain

TEARDOWN: tests/azure_eventgrid_domain

SUMMARY:

1/1 passed.

Example query results

Results

Basic info

select
  name,
  id,
  type,
  provisioning_state
from
  azure_eventgrid_domain;

+-------------+--------------------------------------------------------------------------------------------------------------------------------+-----------------------------+--------------------+
| name        | id                                                                                                                             | type                        | provisioning_state |
+-------------+--------------------------------------------------------------------------------------------------------------------------------+-----------------------------+--------------------+
| test-domain | /subscriptions/d46d7416-f95f-4771-bbb5-529d4c76659c/resourceGroups/turbot_rg/providers/Microsoft.EventGrid/domains/test-domain | Microsoft.EventGrid/domains | Succeeded          |
+-------------+--------------------------------------------------------------------------------------------------------------------------------+-----------------------------+--------------------+

List domains configured with private endpoint connections

select
  name,
  id,
  type,
  private_endpoint_connections
from
  azure_eventgrid_domain
where
  private_endpoint_connections is not null;

+-------------+--------------------------------------------------------------------------------------------------------------------------------+-----------------------------+------------------------------
| name        | id                                                                                                                             | type                        | private_endpoint_connections 
+-------------+--------------------------------------------------------------------------------------------------------------------------------+-----------------------------+------------------------------
| test-domain | /subscriptions/d46d7416-f95f-4771-bbb5-529d4c76659c/resourceGroups/turbot_rg/providers/Microsoft.EventGrid/domains/test-domain | Microsoft.EventGrid/domains | [{"properties":{"groupIds":["
+-------------+--------------------------------------------------------------------------------------------------------------------------------+-----------------------------+-----------------------------

bigdatasourav · 2021-09-15T06:35:50Z

azure/table_azure_eventgrid_domain.go

+			},
+			{
+				Name:        "provisioning_state",
+				Description: "Provisioning state of the Event Grid Domain Resource, Possible values include: 'DomainProvisioningStateCreating', 'DomainProvisioningStateUpdating', 'DomainProvisioningStateDeleting', 'DomainProvisioningStateSucceeded', 'DomainProvisioningStateCanceled', 'DomainProvisioningStateFailed'.",


Suggested change

Description: "Provisioning state of the Event Grid Domain Resource, Possible values include: 'DomainProvisioningStateCreating', 'DomainProvisioningStateUpdating', 'DomainProvisioningStateDeleting', 'DomainProvisioningStateSucceeded', 'DomainProvisioningStateCanceled', 'DomainProvisioningStateFailed'.",

Description: "Provisioning state of the event grid domain resource. Possible values include: 'Creating', 'Updating', 'Deleting', 'Succeeded', 'Canceled', 'Failed'.",

bigdatasourav · 2021-09-15T06:36:55Z

azure/table_azure_eventgrid_domain.go

+			},
+			{
+				Name:        "auto_create_topic_with_first_subscription",
+				Description: "This Boolean is used to specify the creation mechanism for 'all' the Event Grid Domain Topics associated with this Event Grid Domain resource.",


Suggested change

Description: "This Boolean is used to specify the creation mechanism for 'all' the Event Grid Domain Topics associated with this Event Grid Domain resource.",

Description: "This Boolean is used to specify the creation mechanism for 'all' the event grid domain topics associated with this event grid domain resource.",

bigdatasourav · 2021-09-15T06:38:03Z

azure/table_azure_eventgrid_domain.go

+				Name:        "created_by_type",
+				Description: "The type of identity that created the resource.",
+				Type:        proto.ColumnType_STRING,
+				Transform:   transform.FromField("SystemData.CreatedByType").Transform(convertDateToTime),


is CreatedByType a dateTime field?

bigdatasourav · 2021-09-15T06:40:11Z

azure/table_azure_eventgrid_domain.go

+			},
+			{
+				Name:        "diagnostic_settings",
+				Description: "A list of active diagnostic settings for the eventhub namespace.",


description is not correct

bigdatasourav · 2021-09-15T06:41:06Z

azure/table_azure_eventgrid_domain.go

+				Name:        "input_schema_mapping",
+				Description: "Information about the InputSchemaMapping which specified the info about mapping event payload.",
+				Type:        proto.ColumnType_JSON,
+				Transform: transform.FromField("InputSchemaMapping"),


do we need transform function here?

bigdatasourav · 2021-09-15T06:41:35Z

azure/table_azure_eventgrid_domain.go

+				Transform:   transform.FromField("ID").Transform(idToAkas),
+			},
+
+			// Azure standard column


Suggested change

// Azure standard column

// Azure standard columns

bigdatasourav · 2021-09-15T06:46:56Z

azure/table_azure_eventgrid_domain.go

+	client.Authorizer = session.Authorizer
+	top := int32(100)
+
+	result, err := client.ListBySubscription(ctx, "", &top)


check with client.ListBySubscription(ctx, "", nil)

It will work if we specify top param as nil, it will fallback to default value that is 20 per page

bigdatasourav · 2021-09-23T11:01:34Z

azure/table_azure_eventgrid_domain.go

+			},
+			{
+				Name:        "identity_type",
+				Description: "The type of managed identity used. The type 'SystemAssigned, UserAssigned' includes both an implicitly created identity and a set of user-assigned identities. The type 'None' will remove any identity. Possible values include: 'IdentityTypeNone', 'IdentityTypeSystemAssigned', 'IdentityTypeUserAssigned', 'IdentityTypeSystemAssignedUserAssigned'.",


update possible values.

bigdatasourav

LGTM

ParthaI added 2 commits September 9, 2021 14:42

Add table azure_eventgrid_domain closes #293

42304b4

update the doc

0e89b52

ParthaI requested review from khushboo9024 and bigdatasourav September 9, 2021 10:43

ParthaI self-assigned this Sep 9, 2021

Update the example query

60bfdf4

ParthaI linked an issue Sep 9, 2021 that may be closed by this pull request

Add table azure_eventgrid_domain #293

Closed

bigdatasourav reviewed Sep 15, 2021

View reviewed changes

ParthaI added 2 commits September 16, 2021 11:58

Made changes as per review comments

20c0065

Removed the custom structure

33b0ea8

bigdatasourav reviewed Sep 23, 2021

View reviewed changes

Fix description

5048a6b

bigdatasourav approved these changes Sep 23, 2021

View reviewed changes

bigdatasourav merged commit 0f65df1 into main Sep 23, 2021

bigdatasourav deleted the issue-293 branch September 23, 2021 11:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add table azure_eventgrid_domain closes #293 #314

Add table azure_eventgrid_domain closes #293 #314

ParthaI commented Sep 9, 2021

bigdatasourav Sep 15, 2021

bigdatasourav Sep 15, 2021

bigdatasourav Sep 15, 2021 •

edited

Loading

bigdatasourav Sep 15, 2021

bigdatasourav Sep 15, 2021

bigdatasourav Sep 15, 2021

bigdatasourav Sep 15, 2021

ParthaI Sep 16, 2021

bigdatasourav Sep 23, 2021

bigdatasourav left a comment

	Description: "Provisioning state of the Event Grid Domain Resource, Possible values include: 'DomainProvisioningStateCreating', 'DomainProvisioningStateUpdating', 'DomainProvisioningStateDeleting', 'DomainProvisioningStateSucceeded', 'DomainProvisioningStateCanceled', 'DomainProvisioningStateFailed'.",
	Description: "Provisioning state of the event grid domain resource. Possible values include: 'Creating', 'Updating', 'Deleting', 'Succeeded', 'Canceled', 'Failed'.",

	Description: "This Boolean is used to specify the creation mechanism for 'all' the Event Grid Domain Topics associated with this Event Grid Domain resource.",
	Description: "This Boolean is used to specify the creation mechanism for 'all' the event grid domain topics associated with this event grid domain resource.",

Add table azure_eventgrid_domain closes #293 #314

Add table azure_eventgrid_domain closes #293 #314

Conversation

ParthaI commented Sep 9, 2021

Integration test logs

Example query results

Basic info

List domains configured with private endpoint connections

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bigdatasourav Sep 15, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bigdatasourav left a comment

Choose a reason for hiding this comment

bigdatasourav Sep 15, 2021 •

edited

Loading