Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add table azure_application_gateway. Closes #311 #316

Merged
merged 4 commits into from
Sep 24, 2021
Merged

Add table azure_application_gateway. Closes #311 #316

merged 4 commits into from
Sep 24, 2021

Conversation

c0d3r-arnab
Copy link
Contributor

Integration test logs

Logs 
arnab@turbotindias-MacBook-Pro azure-test % ./tint.js azure_application_gateway
No env file present for the current environment:  staging 
 Falling back to .env config
No env file present for the current environment:  staging
customEnv TURBOT_TEST_EXPECTED_TIMEOUT undefined

SETUP: tests/azure_application_gateway []

PRETEST: tests/azure_application_gateway

TEST: tests/azure_application_gateway
Running terraform

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # azurerm_application_gateway.named_test_resource will be created
  + resource "azurerm_application_gateway" "named_test_resource" {
      + id                  = (known after apply)
      + location            = "westeurope"
      + name                = "turbottest62758"
      + resource_group_name = "turbottest62758"

      + backend_address_pool {
          + id   = (known after apply)
          + name = "turbottest62758-beap"
        }

      + backend_http_settings {
          + cookie_based_affinity               = "Disabled"
          + id                                  = (known after apply)
          + name                                = "turbottest62758-be-htst"
          + path                                = "/path1/"
          + pick_host_name_from_backend_address = false
          + port                                = 80
          + probe_id                            = (known after apply)
          + protocol                            = "Http"
          + request_timeout                     = 60
        }

      + frontend_ip_configuration {
          + id                            = (known after apply)
          + name                          = "turbottest62758-feip"
          + private_ip_address            = (known after apply)
          + private_ip_address_allocation = (known after apply)
          + public_ip_address_id          = (known after apply)
          + subnet_id                     = (known after apply)
        }

      + frontend_port {
          + id   = (known after apply)
          + name = "turbottest62758-feport"
          + port = 80
        }

      + gateway_ip_configuration {
          + id        = (known after apply)
          + name      = "turbottest62758"
          + subnet_id = (known after apply)
        }

      + http_listener {
          + frontend_ip_configuration_id   = (known after apply)
          + frontend_ip_configuration_name = "turbottest62758-feip"
          + frontend_port_id               = (known after apply)
          + frontend_port_name             = "turbottest62758-feport"
          + id                             = (known after apply)
          + name                           = "turbottest62758-httplstn"
          + protocol                       = "Http"
          + ssl_certificate_id             = (known after apply)
        }

      + request_routing_rule {
          + backend_address_pool_id    = (known after apply)
          + backend_address_pool_name  = "turbottest62758-beap"
          + backend_http_settings_id   = (known after apply)
          + backend_http_settings_name = "turbottest62758-be-htst"
          + http_listener_id           = (known after apply)
          + http_listener_name         = "turbottest62758-httplstn"
          + id                         = (known after apply)
          + name                       = "turbottest62758-rqrt"
          + redirect_configuration_id  = (known after apply)
          + rewrite_rule_set_id        = (known after apply)
          + rule_type                  = "Basic"
          + url_path_map_id            = (known after apply)
        }

      + sku {
          + capacity = 2
          + name     = "Standard_Small"
          + tier     = "Standard"
        }

      + ssl_policy {
          + cipher_suites        = (known after apply)
          + disabled_protocols   = (known after apply)
          + min_protocol_version = (known after apply)
          + policy_name          = (known after apply)
          + policy_type          = (known after apply)
        }
    }

  # azurerm_public_ip.named_test_resource will be created
  + resource "azurerm_public_ip" "named_test_resource" {
      + allocation_method       = "Dynamic"
      + availability_zone       = (known after apply)
      + fqdn                    = (known after apply)
      + id                      = (known after apply)
      + idle_timeout_in_minutes = 4
      + ip_address              = (known after apply)
      + ip_version              = "IPv4"
      + location                = "westeurope"
      + name                    = "turbottest62758"
      + resource_group_name     = "turbottest62758"
      + sku                     = "Basic"
      + sku_tier                = "Regional"
      + zones                   = (known after apply)
    }

  # azurerm_resource_group.named_test_resource will be created
  + resource "azurerm_resource_group" "named_test_resource" {
      + id       = (known after apply)
      + location = "westeurope"
      + name     = "turbottest62758"
    }

  # azurerm_subnet.backend will be created
  + resource "azurerm_subnet" "backend" {
      + address_prefix                                 = (known after apply)
      + address_prefixes                               = [
          + "10.254.2.0/24",
        ]
      + enforce_private_link_endpoint_network_policies = false
      + enforce_private_link_service_network_policies  = false
      + id                                             = (known after apply)
      + name                                           = "turbottest62758"
      + resource_group_name                            = "turbottest62758"
      + virtual_network_name                           = "turbottest62758"
    }

  # azurerm_subnet.frontend will be created
  + resource "azurerm_subnet" "frontend" {
      + address_prefix                                 = (known after apply)
      + address_prefixes                               = [
          + "10.254.0.0/24",
        ]
      + enforce_private_link_endpoint_network_policies = false
      + enforce_private_link_service_network_policies  = false
      + id                                             = (known after apply)
      + name                                           = "turbottest62758"
      + resource_group_name                            = "turbottest62758"
      + virtual_network_name                           = "turbottest62758"
    }

  # azurerm_virtual_network.named_test_resource will be created
  + resource "azurerm_virtual_network" "named_test_resource" {
      + address_space         = [
          + "10.254.0.0/16",
        ]
      + dns_servers           = (known after apply)
      + guid                  = (known after apply)
      + id                    = (known after apply)
      + location              = "westeurope"
      + name                  = "turbottest62758"
      + resource_group_name   = "turbottest62758"
      + subnet                = (known after apply)
      + vm_protection_enabled = false
    }

Plan: 6 to add, 0 to change, 0 to destroy.

Changes to Outputs:
  + region             = "westeurope"
  + resource_aka       = (known after apply)
  + resource_aka_lower = (known after apply)
  + resource_id        = (known after apply)
  + resource_name      = "turbottest62758"
  + subscription_id    = "d46d7416-f95f-4771-bbb5-529d4c76659c"
azurerm_resource_group.named_test_resource: Creating...
azurerm_resource_group.named_test_resource: Creation complete after 3s [id=/subscriptions/d46d7416-f95f-4771-bbb5-529d4c76659c/resourceGroups/turbottest62758]
azurerm_virtual_network.named_test_resource: Creating...
azurerm_public_ip.named_test_resource: Creating...
azurerm_public_ip.named_test_resource: Creation complete after 7s [id=/subscriptions/d46d7416-f95f-4771-bbb5-529d4c76659c/resourceGroups/turbottest62758/providers/Microsoft.Network/publicIPAddresses/turbottest62758]
azurerm_virtual_network.named_test_resource: Creation complete after 9s [id=/subscriptions/d46d7416-f95f-4771-bbb5-529d4c76659c/resourceGroups/turbottest62758/providers/Microsoft.Network/virtualNetworks/turbottest62758]
azurerm_subnet.frontend: Creating...
azurerm_subnet.backend: Creating...
azurerm_subnet.frontend: Creation complete after 5s [id=/subscriptions/d46d7416-f95f-4771-bbb5-529d4c76659c/resourceGroups/turbottest62758/providers/Microsoft.Network/virtualNetworks/turbottest62758/subnets/turbottest62758]
azurerm_application_gateway.named_test_resource: Creating...
azurerm_subnet.backend: Creation complete after 9s [id=/subscriptions/d46d7416-f95f-4771-bbb5-529d4c76659c/resourceGroups/turbottest62758/providers/Microsoft.Network/virtualNetworks/turbottest62758/subnets/turbottest62758]
azurerm_application_gateway.named_test_resource: Still creating... [10s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [20s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [30s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [40s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [50s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [1m0s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [1m10s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [1m20s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [1m30s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [1m40s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [1m50s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [2m0s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [2m10s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [2m20s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [2m30s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [2m40s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [2m50s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [3m0s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [3m10s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [3m20s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [3m30s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [3m40s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [3m50s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [4m0s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [4m10s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [4m20s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [4m30s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [4m40s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [4m50s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [5m0s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [5m10s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [5m20s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [5m30s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [5m40s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [5m50s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [6m0s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [6m10s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [6m20s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [6m30s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [6m40s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [6m50s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [7m0s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [7m10s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [7m20s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [7m30s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [7m40s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [7m50s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [8m0s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [8m10s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [8m20s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [8m30s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [8m40s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [8m50s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [9m0s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [9m10s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [9m20s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [9m30s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [9m40s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [9m50s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [10m0s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [10m10s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [10m20s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [10m30s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [10m40s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [10m50s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [11m0s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [11m10s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [11m20s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [11m30s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [11m40s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [11m50s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [12m0s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [12m10s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [12m20s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [12m30s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [12m40s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [12m50s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [13m0s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [13m10s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [13m20s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [13m30s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [13m40s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [13m50s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [14m0s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [14m10s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [14m20s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [14m30s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [14m40s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [14m50s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [15m0s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [15m10s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [15m20s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [15m30s elapsed]
azurerm_application_gateway.named_test_resource: Still creating... [15m40s elapsed]
azurerm_application_gateway.named_test_resource: Creation complete after 15m43s [id=/subscriptions/d46d7416-f95f-4771-bbb5-529d4c76659c/resourceGroups/turbottest62758/providers/Microsoft.Network/applicationGateways/turbottest62758]

Apply complete! Resources: 6 added, 0 changed, 0 destroyed.

Outputs:

region = "westeurope"
resource_aka = "azure:///subscriptions/d46d7416-f95f-4771-bbb5-529d4c76659c/resourceGroups/turbottest62758/providers/Microsoft.Network/applicationGateways/turbottest62758"
resource_aka_lower = "azure:///subscriptions/d46d7416-f95f-4771-bbb5-529d4c76659c/resourcegroups/turbottest62758/providers/microsoft.network/applicationgateways/turbottest62758"
resource_id = "/subscriptions/d46d7416-f95f-4771-bbb5-529d4c76659c/resourceGroups/turbottest62758/providers/Microsoft.Network/applicationGateways/turbottest62758"
resource_name = "turbottest62758"
subscription_id = "d46d7416-f95f-4771-bbb5-529d4c76659c"

Running SQL query: test-get-query.sql
[
  {
    "id": "/subscriptions/d46d7416-f95f-4771-bbb5-529d4c76659c/resourceGroups/turbottest62758/providers/Microsoft.Network/applicationGateways/turbottest62758",
    "name": "turbottest62758",
    "region": "westeurope",
    "resource_group": "turbottest62758",
    "subscription_id": "d46d7416-f95f-4771-bbb5-529d4c76659c",
    "type": "Microsoft.Network/applicationGateways"
  }
]
✔ PASSED

Running SQL query: test-list-query.sql
[
  {
    "id": "/subscriptions/d46d7416-f95f-4771-bbb5-529d4c76659c/resourceGroups/turbottest62758/providers/Microsoft.Network/applicationGateways/turbottest62758",
    "name": "turbottest62758",
    "region": "westeurope",
    "resource_group": "turbottest62758",
    "subscription_id": "d46d7416-f95f-4771-bbb5-529d4c76659c",
    "type": "Microsoft.Network/applicationGateways"
  }
]
✔ PASSED

Running SQL query: test-not-found-query.sql
null
✔ PASSED

Running SQL query: test-turbot-query.sql
[
  {
    "akas": [
      "azure:///subscriptions/d46d7416-f95f-4771-bbb5-529d4c76659c/resourceGroups/turbottest62758/providers/Microsoft.Network/applicationGateways/turbottest62758",
      "azure:///subscriptions/d46d7416-f95f-4771-bbb5-529d4c76659c/resourcegroups/turbottest62758/providers/microsoft.network/applicationgateways/turbottest62758"
    ],
    "name": "turbottest62758",
    "title": "turbottest62758"
  }
]
✔ PASSED

POSTTEST: tests/azure_application_gateway

TEARDOWN: tests/azure_application_gateway


Error: deleting Subnet: (Name "turbottest62758" / Virtual Network Name "turbottest62758" / Resource Group "turbottest62758"): network.SubnetsClient#Delete: Failure sending request: StatusCode=0 -- Original Error: Code="InUseSubnetCannotBeDeleted" Message="Subnet turbottest62758 is in use by /subscriptions/d46d7416-f95f-4771-bbb5-529d4c76659c/resourceGroups/turbottest62758/providers/Microsoft.Network/applicationGateways/turbottest62758/gatewayIPConfigurations/turbottest62758 and cannot be deleted. In order to delete the subnet, delete all the resources within the subnet. See aka.ms/deletesubnet." Details=[]

SUMMARY:

1/1 passed.

Example query results

Results 
> select
  id,
  name,
  type,
  provisioning_state,
  region
from
  azure_application_gateway;
+------------------------------------------------------------------------------------------------------------------------------------------------------------------+---------------------+------------------
| id                                                                                                                                                               | name                | type             
+------------------------------------------------------------------------------------------------------------------------------------------------------------------+---------------------+------------------
| /subscriptions/d46d7416-f95f-4771-bbb5-529d4c76659c/resourceGroups/arnab-test-resource-group/providers/Microsoft.Network/applicationGateways/test-ag-standard-v2 | test-ag-standard-v2 | Microsoft.Network
+------------------------------------------------------------------------------------------------------------------------------------------------------------------+---------------------+------------------
> select
  id,
  name,
  jsonb_pretty(web_application_firewall_configuration -> 'disabledRuleGroups') as disabled_rule_groups,
  web_application_firewall_configuration -> 'enabled' as enabled,
  jsonb_pretty(web_application_firewall_configuration -> 'exclusions') as exclusions,
  web_application_firewall_configuration -> 'fileUploadLimitInMb' as file_upload_limit_in_mb,
  web_application_firewall_configuration -> 'firewallMode' as firewall_mode,
  web_application_firewall_configuration -> 'maxRequestBodySizeInKb' as max_request_body_size_in_kb,
  web_application_firewall_configuration -> 'requestBodyCheck' as request_body_check,
  web_application_firewall_configuration -> 'ruleSetType' as rule_set_type,
  web_application_firewall_configuration -> 'ruleSetVersion' as rule_set_version
from
  azure_application_gateway;
+------------------------------------------------------------------------------------------------------------------------------------------------------------------+---------------------+------------------
| id                                                                                                                                                               | name                | disabled_rule_gro
+------------------------------------------------------------------------------------------------------------------------------------------------------------------+---------------------+------------------
| /subscriptions/d46d7416-f95f-4771-bbb5-529d4c76659c/resourceGroups/arnab-test-resource-group/providers/Microsoft.Network/applicationGateways/test-ag-standard-v2 | test-ag-standard-v2 | [                
|                                                                                                                                                                  |                     | ]                
|                                                                                                                                                                  |                     |                  
|                                                                                                                                                                  |                     |                  
|                                                                                                                                                                  |                     |                  
+------------------------------------------------------------------------------------------------------------------------------------------------------------------+---------------------+------------------
> select
  id,
  name,
  listeners -> 'id' as listener_id,
  listeners -> 'name' as listener_name,
  jsonb_pretty(listeners -> 'properties' -> 'frontendPort') as listener_frontend_port,
  jsonb_pretty(listeners -> 'properties' -> 'hostNames') as listener_host_names,
  listeners -> 'properties' -> 'protocol' as listener_protocol,
  listeners -> 'properties' -> 'requireServerNameIndication' as listener_require_server_name_indication
from
  azure_application_gateway,
  jsonb_array_elements(http_listeners) as listeners;
+------------------------------------------------------------------------------------------------------------------------------------------------------------------+---------------------+------------------
| id                                                                                                                                                               | name                | listener_id      
+------------------------------------------------------------------------------------------------------------------------------------------------------------------+---------------------+------------------
| /subscriptions/d46d7416-f95f-4771-bbb5-529d4c76659c/resourceGroups/arnab-test-resource-group/providers/Microsoft.Network/applicationGateways/test-ag-standard-v2 | test-ag-standard-v2 | "/subscriptions/d
|                                                                                                                                                                  |                     |                  
|                                                                                                                                                                  |                     |                  
+------------------------------------------------------------------------------------------------------------------------------------------------------------------+---------------------+------------------
> select
  id,
  name,
  settings -> 'id' as settings_id,
  settings -> 'name' as settings_name,
  settings -> 'properties' -> 'cookieBasedAffinity' as settings_cookie_based_affinity,
  settings -> 'properties' -> 'pickHostNameFromBackendAddress' as settings_pick_host_name_from_backend_address,
  settings -> 'properties' -> 'port' as settings_port,
  settings -> 'properties' -> 'protocol' as settings_protocol,
  settings -> 'properties' -> 'requestTimeout' as settings_request_timeout
from
  azure_application_gateway,
  jsonb_array_elements(backend_http_settings_collection) as settings;
+------------------------------------------------------------------------------------------------------------------------------------------------------------------+---------------------+------------------
| id                                                                                                                                                               | name                | settings_id      
+------------------------------------------------------------------------------------------------------------------------------------------------------------------+---------------------+------------------
| /subscriptions/d46d7416-f95f-4771-bbb5-529d4c76659c/resourceGroups/arnab-test-resource-group/providers/Microsoft.Network/applicationGateways/test-ag-standard-v2 | test-ag-standard-v2 | "/subscriptions/d
+------------------------------------------------------------------------------------------------------------------------------------------------------------------+---------------------+------------------
> select
  id,
  name,
  config -> 'id' as config_id,
  config -> 'name' as config_name,
  jsonb_pretty(config -> 'properties' -> 'publicIPAddress') as config_public_ip_address,
  config -> 'properties' -> 'privateIPAllocationMethod' as config_private_ip_allocation_method
from
  azure_application_gateway,
  jsonb_array_elements(frontend_ip_configurations) as config;
+------------------------------------------------------------------------------------------------------------------------------------------------------------------+---------------------+------------------
| id                                                                                                                                                               | name                | config_id        
+------------------------------------------------------------------------------------------------------------------------------------------------------------------+---------------------+------------------
| /subscriptions/d46d7416-f95f-4771-bbb5-529d4c76659c/resourceGroups/arnab-test-resource-group/providers/Microsoft.Network/applicationGateways/test-ag-standard-v2 | test-ag-standard-v2 | "/subscriptions/d
|                                                                                                                                                                  |                     |                  
|                                                                                                                                                                  |                     |                  
+------------------------------------------------------------------------------------------------------------------------------------------------------------------+---------------------+------------------
>

@c0d3r-arnab c0d3r-arnab linked an issue Sep 14, 2021 that may be closed by this pull request
Add table azure_application_gateway #311
Closed
@c0d3r-arnab c0d3r-arnab self-assigned this Sep 14, 2021
bigdatasourav
bigdatasourav reviewed Sep 15, 2021
View reviewed changes
azure/table_azure_application_gateway.go Outdated

type ApplicationGatewayInfo struct {
ApplicationGateway network.ApplicationGateway
Properties ApplicationGatewayPropertiesInfo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need a custom structure? for example - transform.fromField("ApplicationGatewayPropertiesFormat.Sku") will not work?

bigdatasourav
bigdatasourav approved these changes Sep 24, 2021
View reviewed changes
Copy link
Contributor

@bigdatasourav bigdatasourav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bigdatasourav bigdatasourav merged commit aae9a24 into main Sep 24, 2021
@bigdatasourav bigdatasourav deleted the issue-311 branch September 24, 2021 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigdatasourav bigdatasourav bigdatasourav approved these changes

@ParthaI ParthaI Awaiting requested review from ParthaI

Assignees

@c0d3r-arnab c0d3r-arnab

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add table azure_application_gateway
2 participants
@c0d3r-arnab @bigdatasourav