Fix GetNewSession function to cache credentials session correctly. Fixes #441 #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 19, 2022 18:17
…n id is not known for CLI auth
cbruno10
reviewed
Jan 19, 2022
azure/service.go
Outdated
| @@ -49,6 +50,7 @@ func GetNewSession(ctx context.Context, d *plugin.QueryData, tokenAudience strin | |||
| return cachedData.(*Session), nil | |||
| } | |||
| } | |||
| logger.Info("Auth session not found in cache") | |||
There was a problem hiding this comment.
Should this be info level, or debug instead? I don't know if we want to see this all the time in the logs.
azure/service.go
Outdated
| @@ -153,7 +155,9 @@ func GetNewSession(ctx context.Context, d *plugin.QueryData, tokenAudience strin | |||
|
|
|||
| // Get the subscription ID and tenant ID for "GRAPH" token audience | |||
| case "CLI": | |||
| logger.Info("GetNewSession__", "Get session authorizer from Azure CLI") | |||
There was a problem hiding this comment.
Similarly here, should this be debug level instead?
azure/service.go
Outdated
| authorizer, err = auth.NewAuthorizerFromCLIWithResource(resource) | ||
| // authorizer |
There was a problem hiding this comment.
What does this comment mean?
azure/service.go
Outdated
|
|
||
| if err != nil { | ||
| logger.Debug("GetNewSession__", "NewAuthorizerFromCLIWithResource error", err) | ||
| logger.Error("GetNewSession__", "Get token from Azure CLI error", err) |
There was a problem hiding this comment.
What level do we usually use, Warn or Error, for these types of messages?
azure/service.go
Outdated
| d.ConnectionManager.Cache.SetWithTTL(cacheKey, sess, time.Until(*sess.Expires)) | ||
| logger.Info("Session saved in cache with expiry in", "minutes", (time.Until(*sess.Expires)).Minutes()) |
There was a problem hiding this comment.
Similar to my other questions above, should this line and the one below it be debug level?
cbruno10
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration test logs
Logs
Example query results
Results