Add source_types config arg to replace source_type
#167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbruno10
commented
Sep 26, 2023
| @@ -11,6 +11,7 @@ type kubernetesConfig struct { | |||
| CustomResourceTables []string `hcl:"custom_resource_tables,optional"` | |||
| ManifestFilePaths []string `hcl:"manifest_file_paths,optional" steampipe:"watch"` | |||
| SourceType *string `hcl:"source_type,optional"` | |||
| SourceTypes []string `hcl:"source_types,optional"` | |||
There was a problem hiding this comment.
For expected behaviours:
- The default for
source_typesshould include all current values and should be commented out - If
source_typesis not set/null, then we should attempt to load all source types - If
source_types = [], then we should not error and load no data (like we do whenpaths = []in this plugin and others) - If
source_typeandsource_typesare both set,source_typesshould win - Documentation should only mention
source_typesnow
… source_types wins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes deprecating the
source_typeconfig arg in favor ofsource_types, which includes a list of source types and eliminates the use of anallvalues. The main advantage is being able to include a specific combination, e.g., only load helm and manifest resources, but not deployed, which is not possible with just thesource_typeconfig arg.The
source_typearg will continue work, includingsource_type = 'all'translating tosource_types = ['deployed', 'helm', 'manifest'].