Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service application authentication #22

Merged
merged 2 commits into from
Aug 19, 2021
Merged

Add service application authentication #22

merged 2 commits into from
Aug 19, 2021

Conversation

ctennis
Copy link
Contributor

@ctennis ctennis commented Aug 16, 2021

I can confirm this works great, and is a much more secure way of configuring API access into Okta (though is a bit more work to initially setup).

@cbruno10
Copy link
Contributor

Thanks @ctennis for the pull request! We'll review this tomorrow and let you know if we have any feedback.

@cbruno10 cbruno10 requested a review from LalitLab August 16, 2021 21:21
okta/connect.go Outdated Show resolved Hide resolved
okta/connect.go Outdated Show resolved Hide resolved
Copy link
Contributor

@LalitLab LalitLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctennis
Thanks, for raising PR for adding service application authentication mode.
Most of the changes look good.

I have left few suggestions on PR after testing it on my side.

@cbruno10
Copy link
Contributor

@ctennis Hey, while testing and looking for additional scopes, we couldn't seem to find the scope to include for the okta_user_type table; when we try to query that table using a private key, we receive an error. Just curious, did you run across any scopes for this resource type while searching?

@ctennis
Copy link
Contributor Author

ctennis commented Aug 17, 2021

@ctennis Hey, while testing and looking for additional scopes, we couldn't seem to find the scope to include for the okta_user_type table; when we try to query that table using a private key, we receive an error. Just curious, did you run across any scopes for this resource type while searching?

You're right, I can't seem to find a scope here either. I'll open a service ticket with Okta, the API for this lives under the /meta hierarchy and I wonder if they just overlooked it.

@ctennis
Copy link
Contributor Author

ctennis commented Aug 17, 2021

Confirmed with Okta, this particular API isn't supported via oauth. I upvoted the case regarding it. Not a blocker for us, but I suppose a limitation of this particular table.

https://ideas.okta.com/app/#/case/132309

@LalitLab
Copy link
Contributor

Confirmed with Okta, this particular API isn't supported via oauth. I upvoted the case regarding it. Not a blocker for us, but I suppose a limitation of this particular table.

https://ideas.okta.com/app/#/case/132309

Thank you for checking the details that far.

@cbruno10 cbruno10 merged commit 3456316 into turbot:main Aug 19, 2021
@cbruno10
Copy link
Contributor

Thanks again @ctennis for the contribution, appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants