-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add table okta_factor. Closes #17 #30
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
okta/table_okta_factor.go
Outdated
|
||
// JSON Columns | ||
{Name: "embedded", Type: proto.ColumnType_JSON, Description: "The embedded properties of the factor .", Transform: transform.FromField("Factor.Embedded")}, | ||
{Name: "links", Type: proto.ColumnType_JSON, Description: "The link properties of the factor.", Transform: transform.FromField("Factor.Links")}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{Name: "links", Type: proto.ColumnType_JSON, Description: "The link properties of the factor.", Transform: transform.FromField("Factor.Links")}, |
Also update examples for same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@c0d3r-arnab
Please update the code for scope
to read okta factors in the private key authentication method
The query returns data without the private key authentication method:
|
okta/table_okta_factor.go
Outdated
Columns: []*plugin.Column{ | ||
// Top Columns | ||
{Name: "id", Type: proto.ColumnType_STRING, Description: "A unique key for the factor.", Transform: transform.FromField("Factor.Id")}, | ||
{Name: "user_id", Type: proto.ColumnType_STRING, Description: "A unique key for the user."}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also bring users login name for an easier look up of the data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the user login name column
select * from okta_factor where id = 'ost1m64qvuJk6dICv5d7' and user_id = '00u1kcfw5yDiVG80P5d7';
+----------------------+----------------------+-------------------+---------------------+---------------------+---------------------+----------+--------------------+----------+--------+----------------------+
| id | user_id | user_name | factor_type | created | last_updated | provider | status | embedded | verify | title |
+----------------------+----------------------+-------------------+---------------------+---------------------+---------------------+----------+--------------------+----------+--------+----------------------+
| ost1m64qvuJk6dICv5d7 | 00u1kcfw5yDiVG80P5d7 | partha@turbot.com | token:software:totp | 2021-08-30 12:53:16 | 2021-08-30 12:53:16 | OKTA | PENDING_ACTIVATION | <null> | <null> | ost1m64qvuJk6dICv5d7 |
+----------------------+----------------------+-------------------+---------------------+---------------------+---------------------+----------+--------------------+----------+--------+----------------------+
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@c0d3r-arnab
Left comment to add user login name field
Example query results
Results