-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add table okta_trusted_origin. Closes #15 #31
Conversation
okta/table_okta_trusted_origin.go
Outdated
|
||
app, _, err := client.TrustedOrigin.GetOrigin(ctx, trustedOriginId) | ||
if err != nil { | ||
logger.Error("getOktaTrustedOrigin", "get application", err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the error message.
docs/tables/okta_trusted_origin.md
Outdated
okta_trusted_origin; | ||
``` | ||
|
||
### List trusted origins last updated for more than 30 days |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### List trusted origins last updated for more than 30 days | |
### List trusted origins for more than 30 days of last updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
docs/tables/okta_trusted_origin.md
Outdated
okta_trusted_origin; | ||
``` | ||
|
||
### List trusted origins for more than 30 days since last updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### List trusted origins for more than 30 days since last updated | |
### List trusted origins last updated 30 days ago |
okta/table_okta_trusted_origin.go
Outdated
|
||
// JSON Columns | ||
{Name: "scopes", Type: proto.ColumnType_JSON, Description: "The scopes for the trusted origin. Valid values are 'CORS' or 'REDIRECT'."}, | ||
{Name: "links", Type: proto.ColumnType_JSON, Description: "The trusted origin link properties."}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{Name: "links", Type: proto.ColumnType_JSON, Description: "The trusted origin link properties."}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update examples for the change
okta/table_okta_trusted_origin.go
Outdated
func tableOktaTrustedOrigin() *plugin.Table { | ||
return &plugin.Table{ | ||
Name: "okta_trusted_origin", | ||
Description: "Okta Trusted Origin", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update it some usefult de
Description: "Okta Trusted Origin", | |
Description: "Trusted Origin is a security-based concept that combines the URI scheme, hostname, and port number of a page.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@c0d3r-arnab left few comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Example query results
Results