-
Notifications
You must be signed in to change notification settings - Fork 1
Add table turbot_grant closes #12 #15
Conversation
turbot/turbot_active_grant.go
Outdated
}, | ||
Columns: []*plugin.Column{ | ||
// Top columns | ||
{Name: "id", Type: proto.ColumnType_INT, Transform: transform.FromField("Turbot.ID"), Description: "Unique identifier of the grant."}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{Name: "id", Type: proto.ColumnType_INT, Transform: transform.FromField("Turbot.ID"), Description: "Unique identifier of the grant."}, | |
{Name: "id", Type: proto.ColumnType_INT, Transform: transform.FromField("Turbot.ID"), Description: "Unique identifier of the grantee."}, |
grant > grantee or actor
@ParthaI I would suggest having a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see suggestions
General guidelines:
- Convert the field name into snake case
- Omit the word
turbot
in the column name - Sometimes add the word
grant
oractive_grant
if there's ambiguity with another column name that's very close, e.g.,identity_status
vs.grant_status
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ParthaI Please see comments, thanks!
A lot of comments are around field naming, we had established some guidelines in #15 (review), was there a reason you deviated from these here?
Also, I think there's a similar column naming issue I didn't include in this review, but did for active_grant here #24 (comment).
docs/tables/turbot_grant.md
Outdated
|
||
## Examples | ||
|
||
### List all turbot grants |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### List all turbot grants | |
### Basic info |
turbot/table_turbot_grant.go
Outdated
{Name: "level_title", Type: proto.ColumnType_STRING, Transform: transform.FromField("Level.Title"), Description: "The title of the level."}, | ||
{Name: "level_trunk_title", Type: proto.ColumnType_STRING, Transform: transform.FromField("Level.Trunk.Title"), Description: "Full title (including ancestor trunk) of the level."}, | ||
{Name: "level_uri", Type: proto.ColumnType_STRING, Transform: transform.FromField("Level.URI"), Description: "The URI of the level."}, | ||
{Name: "type_trunk_title", Type: proto.ColumnType_STRING, Transform: transform.FromField("Resource.Type.Trunk.Title"), Description: "Full title (including ancestor trunk) of the grant type."}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this column and the one below not include the word resource
, but the others below it do with similar property paths?
Example query results
Results