Add table turbot_grant closes #12 #15

ParthaI · 2021-11-25T05:01:48Z

Example query results

Results

> select id, identity_status, ientity_family_name,level_trunk_title from turbot_active_grant
+-----------------+-----------------+---------------------+-------------------------------------------------------+
| id              | identity_status | ientity_family_name | level_trunk_title                                     |
+-----------------+-----------------+---------------------+-------------------------------------------------------+
| 161525342357056 | Active          | Smyth               | User > Metadata > ReadOnly > Operator > Admin > Owner |
| 229155810239578 | Active          | Behera              | SuperUser                                             |
| 228825782849182 | Active          | Chakraborty         | SuperUser                                             |
| 216704470305117 | Active          | Das                 | User > Metadata > ReadOnly > Operator > Admin         |
| 232513631394343 | Active          | Behera              | User > Metadata > ReadOnly > Operator                 |
| 240323569425816 | Active          | Behera              | User > Metadata > ReadOnly > Operator > Admin > Owner |
| 165127150940754 | Active          | Kumbha              | User > Metadata > ReadOnly > Operator > Admin > Owner |
| 228825782907553 | Active          | Chakraborty         | User > Metadata > ReadOnly                            |
| 232514598645748 | Active          | Bhardwaj            | Role                                                  |
| 240323894253012 | Active          | Misra               | SuperUser                                             |
| 162687942600473 | Active          | Hadianto            | User > Metadata > ReadOnly > Operator > Admin > Owner |
| 188609043625517 | Active          | Wallace             | User > Metadata > ReadOnly > Operator > Admin > Owner |
| 189875991944587 | Active          | Bhardwaj            | SuperUser                                             |
| 162654220386929 | Active          | Bruno               | User > Metadata > ReadOnly > Operator > Admin > Owner |
| 187951536899783 | Active          | Mohanty             | User > Metadata > ReadOnly > Operator > Admin > Owner |
| 189793356024239 | Active          | Bhardwaj            | User > Metadata > ReadOnly > Operator > Admin > Owner |
| 165127150928460 | Active          | Basu                | User > Metadata > ReadOnly > Operator > Admin > Owner |
| 162199372503739 | Active          | Burgess             | User > Metadata > ReadOnly > Operator > Admin > Owner |
| 240323832580553 | Active          | Misra               | User > Metadata > ReadOnly > Operator > Admin > Owner |
| 162654220385904 | Active          | Bruno               | User > Metadata > ReadOnly > Operator > Admin         |
| 232513631215140 | Active          | Behera              | User > Metadata > ReadOnly > Operator                 |
| 161241086036962 | Active          | Admin               | User > Metadata > ReadOnly > Operator > Admin > Owner |
| 187955963611958 | Active          | Mohanty             | SuperUser                                             |
| 241556185269454 | Inactive        | Nayak               | User > Metadata                                       |
| 212996033743000 | Active          | Khuntia             | User > Metadata > ReadOnly > Operator > Admin         |
+-----------------+-----------------+---------------------+-------------------------------------------------------+

rajlearner17 · 2021-11-25T07:18:13Z

turbot/turbot_active_grant.go

+		},
+		Columns: []*plugin.Column{
+			// Top columns
+			{Name: "id", Type: proto.ColumnType_INT, Transform: transform.FromField("Turbot.ID"), Description: "Unique identifier of the grant."},


Suggested change

{Name: "id", Type: proto.ColumnType_INT, Transform: transform.FromField("Turbot.ID"), Description: "Unique identifier of the grant."},

{Name: "id", Type: proto.ColumnType_INT, Transform: transform.FromField("Turbot.ID"), Description: "Unique identifier of the grantee."},

grant > grantee or actor

rajlearner17 · 2021-11-25T07:33:23Z

@ParthaI I would suggest having a turbot_grant table to capture grantee with status (Active/Inactive) and associated grants (Permissions)

cbruno10

Please see suggestions

General guidelines:

Convert the field name into snake case
Omit the word turbot in the column name
Sometimes add the word grant or active_grant if there's ambiguity with another column name that's very close, e.g., identity_status vs. grant_status

turbot/table_turbot_grant.go

… issue-12

cbruno10

@ParthaI Please see comments, thanks!

A lot of comments are around field naming, we had established some guidelines in #15 (review), was there a reason you deviated from these here?

Also, I think there's a similar column naming issue I didn't include in this review, but did for active_grant here #24 (comment).

docs/tables/turbot_grant.md

cbruno10 · 2022-01-11T15:34:46Z

docs/tables/turbot_grant.md

+
+## Examples
+
+### List all turbot grants


Suggested change

### List all turbot grants

### Basic info

cbruno10 · 2022-01-11T15:35:45Z

turbot/table_turbot_grant.go

+			{Name: "level_title", Type: proto.ColumnType_STRING, Transform: transform.FromField("Level.Title"), Description: "The title of the level."},
+			{Name: "level_trunk_title", Type: proto.ColumnType_STRING, Transform: transform.FromField("Level.Trunk.Title"), Description: "Full title (including ancestor trunk) of the level."},
+			{Name: "level_uri", Type: proto.ColumnType_STRING, Transform: transform.FromField("Level.URI"), Description: "The URI of the level."},
+			{Name: "type_trunk_title", Type: proto.ColumnType_STRING, Transform: transform.FromField("Resource.Type.Trunk.Title"), Description: "Full title (including ancestor trunk) of the grant type."},


Why does this column and the one below not include the word resource, but the others below it do with similar property paths?

Add table turbot_grant and turbot_active_grants closes #12

2257c54

ParthaI self-assigned this Nov 25, 2021

ParthaI marked this pull request as draft November 25, 2021 05:02

rajlearner17 reviewed Nov 25, 2021

View reviewed changes

ParthaI and others added 7 commits November 25, 2021 15:27

Update

7f4d330

Update

b7203c0

Rearrange the comumns in alphabetic order

e786863

Update the qraphql query indentation

6b85323

Update

1ad3ced

Prettify the codes

a6bb406

Update

ebbf558

LalitLab linked an issue Nov 30, 2021 that may be closed by this pull request

Add table turbot_grant #12

Closed

cbruno10 suggested changes Dec 7, 2021

View reviewed changes

ParthaI added 2 commits December 8, 2021 18:13

Separated the two tabels

c51c426

Update the description

d223022

rajlearner17 reviewed Dec 8, 2021

View reviewed changes

turbot/table_turbot_grant.go Outdated Show resolved Hide resolved

rajlearner17 reviewed Dec 8, 2021

View reviewed changes

turbot/table_turbot_grant.go Outdated Show resolved Hide resolved

rajlearner17 reviewed Dec 8, 2021

View reviewed changes

turbot/table_turbot_grant.go Outdated Show resolved Hide resolved

rajlearner17 reviewed Dec 8, 2021

View reviewed changes

turbot/table_turbot_grant.go Outdated Show resolved Hide resolved

ParthaI added 3 commits December 8, 2021 20:18

Updated the description

ec288f6

Updated the description for the columns

df590aa

Merge branch 'main' of github.com:turbot/steampipe-plugin-turbot into…

9cee0c7

… issue-12

ParthaI marked this pull request as ready for review December 8, 2021 15:12

rajlearner17 and others added 2 commits December 8, 2021 21:57

Minor update to description

d20e0ab

Updated the grant table with it's mutation

f9a1b08

ParthaI force-pushed the issue-12 branch from d20e0ab to f9a1b08 Compare December 14, 2021 09:08

Removed the Valiid from timestamp and valid to timestamp from the table

03c22f3

ParthaI changed the title ~~Add table turbot_grant and turbot_active_grants closes #12~~ Add table turbot_grant closes #12 Dec 15, 2021

prettyfied the graphql query

16ba5ba

cbruno10 suggested changes Jan 11, 2022

View reviewed changes

ParthaI and others added 2 commits January 24, 2022 12:12

Added more example in docs

fffc4a6

Update examples

1973d68

cbruno10 approved these changes Jan 24, 2022

View reviewed changes

cbruno10 merged commit 2bbd68c into main Jan 24, 2022

cbruno10 deleted the issue-12 branch January 24, 2022 14:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add table turbot_grant closes #12 #15

Add table turbot_grant closes #12 #15

ParthaI commented Nov 25, 2021 •

edited

Loading

rajlearner17 Nov 25, 2021 •

edited

Loading

rajlearner17 commented Nov 25, 2021

cbruno10 left a comment

cbruno10 left a comment •

edited

Loading

cbruno10 Jan 11, 2022

cbruno10 Jan 11, 2022

	{Name: "id", Type: proto.ColumnType_INT, Transform: transform.FromField("Turbot.ID"), Description: "Unique identifier of the grant."},
	{Name: "id", Type: proto.ColumnType_INT, Transform: transform.FromField("Turbot.ID"), Description: "Unique identifier of the grantee."},

Add table turbot_grant closes #12 #15

Add table turbot_grant closes #12 #15

Conversation

ParthaI commented Nov 25, 2021 • edited Loading

Example query results

rajlearner17 Nov 25, 2021 • edited Loading

Choose a reason for hiding this comment

rajlearner17 commented Nov 25, 2021

cbruno10 left a comment

Choose a reason for hiding this comment

cbruno10 left a comment • edited Loading

Choose a reason for hiding this comment

cbruno10 Jan 11, 2022

Choose a reason for hiding this comment

cbruno10 Jan 11, 2022

Choose a reason for hiding this comment

ParthaI commented Nov 25, 2021 •

edited

Loading

rajlearner17 Nov 25, 2021 •

edited

Loading

cbruno10 left a comment •

edited

Loading