Skip to content
This repository has been archived by the owner on Jul 28, 2023. It is now read-only.

Update tables to improve filtering, context cancellation in list calls #5

Merged
merged 12 commits into from
Oct 29, 2021
Merged

Update tables to improve filtering, context cancellation in list calls #5

merged 12 commits into from
Oct 29, 2021

Conversation

Subhajit97
Copy link
Contributor

@Subhajit97 Subhajit97 commented Sep 15, 2021 •
edited by rajlearner17
Loading

  • Improve filtering by using optional quals.
  • Added context cancellation in list calls.
  • Update table paging to use limit clause (if passed in query) for page limiting.
  • Added column workspace to represent the workspace across all the tables.

Integration test logs

Logs 
Add passing integration test logs here

Example query results

Results 
Add example SQL query results here (please include the input queries as well)

@Subhajit97 Subhajit97 self-assigned this Sep 15, 2021
@Subhajit97 Subhajit97 linked an issue Sep 15, 2021 that may be closed by this pull request
Improve filtering, context cancellation in list calls for tables #4
Closed
@Subhajit97 Subhajit97 marked this pull request as ready for review September 16, 2021 10:47
@cbruno10 cbruno10 requested review from LalitLab and removed request for cbruno10 October 27, 2021 01:50
LalitLab
LalitLab reviewed Oct 29, 2021
View reviewed changes
Copy link
Contributor

@LalitLab LalitLab left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Subhajit97
Left a comment

All the changes looks good

turbot/table_turbot_policy_setting.go Show resolved Hide resolved
LalitLab
LalitLab approved these changes Oct 29, 2021
View reviewed changes
Copy link
Contributor

@LalitLab LalitLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LalitLab LalitLab merged commit f2bdc2e into main Oct 29, 2021
@LalitLab LalitLab deleted the update-opt-quals branch October 29, 2021 11:19
@Subhajit97 Subhajit97 mentioned this pull request Oct 29, 2021
Closed
@Subhajit97 Subhajit97 linked an issue Oct 29, 2021 that may be closed by this pull request
Update steampipe-plugin-sdk to v1.7.0 #10
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@LalitLab LalitLab LalitLab approved these changes

Assignees

@Subhajit97 Subhajit97

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update steampipe-plugin-sdk to v1.7.0 Improve filtering, context cancellation in list calls for tables
2 participants
@Subhajit97 @LalitLab