fix: extract hub.steampipe.io/ as a constant

turbot · Jul 12, 2023 · 2eeffaa · 2eeffaa
1 parent 47e6366
commit 2eeffaa
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/cmd/plugin.go b/cmd/plugin.go
@@ -409,7 +409,7 @@ func runPluginUpdateCmd(cmd *cobra.Command, args []string) {
 			ref := ociinstaller.NewSteampipeImageRef(p)
 			isExists, _ := plugin.Exists(p)
 			if isExists {
-				if strings.HasPrefix(ref.DisplayImageRef(), "hub.steampipe.io/") {
+				if strings.HasPrefix(ref.DisplayImageRef(), constants.SteampipeHubOCIBase) {
 					runUpdatesFor = append(runUpdatesFor, versionData.Plugins[ref.DisplayImageRef()])
 				} else {
 					error_helpers.ShowError(ctx, fmt.Errorf("cannot check updates for plugins not distributed via hub.steampipe.io, you should uninstall then reinstall the plugin to get the latest version"))

diff --git a/pkg/constants/plugin.go b/pkg/constants/plugin.go
@@ -7,4 +7,6 @@ const (
 	InstallMessagePluginNotFound               = "Not found"
 	ConnectionErrorPluginFailedToStart         = "plugin failed to start"
 	ConnectionErrorPluginNotInstalled          = "plugin not installed"
+
+	SteampipeHubOCIBase = "hub.steampipe.io/"
 )
diff --git a/pkg/ociinstaller/imageref.go b/pkg/ociinstaller/imageref.go
@@ -3,6 +3,8 @@ package ociinstaller
 import (
 	"fmt"
 	"strings"
+
+	"github.com/turbot/steampipe/pkg/constants"
 )
 
 const (
@@ -88,7 +90,7 @@ func (r *SteampipeImageRef) GetOrgNameAndStream() (string, string, string) {
 	// plugin.Name looks like `hub.steampipe.io/plugins/turbot/aws@latest`
 	split := strings.Split(r.DisplayImageRef(), "/")
 	pluginNameAndStream := strings.Split(split[len(split)-1], "@")
-	if strings.HasPrefix(r.DisplayImageRef(), "hub.steampipe.io/") {
+	if strings.HasPrefix(r.DisplayImageRef(), constants.SteampipeHubOCIBase) {
 		return split[len(split)-2], pluginNameAndStream[0], pluginNameAndStream[1]
 	}
 	return strings.Join(split[0:len(split)-2], "/"), pluginNameAndStream[0], pluginNameAndStream[1]