Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aggregator with no connections should only be a warning - not an error #3155

Closed
johnsmyth opened this issue Feb 24, 2023 · 0 comments · Fixed by #3166
Closed

aggregator with no connections should only be a warning - not an error #3155

johnsmyth opened this issue Feb 24, 2023 · 0 comments · Fixed by #3166
Assignees
@kaidaguerre
Labels
bug Something isn't working

Comments

@johnsmyth
Copy link

johnsmyth commented Feb 24, 2023 •
edited
Loading

Describe the bug
aggregator with no connections should only be a warning - not an error

Steampipe version (steampipe -v)
probably all, tested with Steampipe v0.19.0-rc.3

To reproduce
create an aggregator that has no / matches no connections and attempt to start steampipe

2023-02-24 15:05:47.740 UTC [WARN]  error loading updated connection config: config validation failed with 1 error: 
  - aggregator connection 'gcp' has no children

Expected behavior
A warn should appear in the log, but steampipe should start anyway

Additional context
Add any other context about the problem here.
@johnsmyth johnsmyth added the bug Something isn't working label Feb 24, 2023
@kaidaguerre kaidaguerre linked a pull request Feb 28, 2023 that will close this issue
aggregator with no connections should only be a warning - not an error. Closes #3155 #3166
Merged
kaidaguerre added a commit that referenced this issue Feb 28, 2023
@kaidaguerre
Aggregator with no connections should only be a warning - not an error.
a936a6d 
Closes #3155

Steampipe config validation failure no longer prevents Steampipe commands from running - instead invalid connections are removed. Closes #3156
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaidaguerre kaidaguerre

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@kaidaguerre @johnsmyth